Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1915953002: Skip GYP if GYP_PDFIUM_NO_ACTION set. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Skip GYP if GYP_PDFIUM_NO_ACTION set. This CL updates the gyp_pdfium script to early exit if GYP_PDFIUM_NO_ACTION=1 is set in the users environment. This allows using GN to generate the out/Debug directory and not have it clobbered on a gclient sync. Committed: https://pdfium.googlesource.com/pdfium/+/ba9ee0748ae03519e54e82c49c6aaa481a6fff21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build_gyp/gyp_pdfium View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-25 13:26:32 UTC) #2
Tom Sepez
Ok, but are folks in the habit of generating their GN builds on top of ...
4 years, 8 months ago (2016-04-25 16:21:10 UTC) #3
dsinclair
On 2016/04/25 16:21:10, Tom Sepez wrote: > Ok, but are folks in the habit of ...
4 years, 8 months ago (2016-04-25 16:47:10 UTC) #4
dsinclair
ping.
4 years, 8 months ago (2016-04-26 14:31:38 UTC) #5
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-26 15:56:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915953002/1
4 years, 8 months ago (2016-04-26 15:57:25 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 16:17:29 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/ba9ee0748ae03519e54e82c49c6aaa481a6f...

Powered by Google App Engine
This is Rietveld 408576698