src/core/SkCanvas.cpp - Issue 1915943002: simplify handle-affine: subclass overrides just describe their leaf behavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkCanvas.cpp

Issue 1915943002: simplify handle-affine: subclass overrides just describe their leaf behavior (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: early out if onCanHandleComplexCTM returns false Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkCanvas.cpp

diff --git a/src/core/SkCanvas.cpp b/src/core/SkCanvas.cpp

index f8731e9ad2004b7c96b36c47a671abcbbce6278e..7552626057a2095c75de041774c1225faf681a45 100644

--- a/src/core/SkCanvas.cpp

+++ b/src/core/SkCanvas.cpp

@@ -1217,7 +1217,7 @@ void SkCanvas::internalSaveLayer(const SaveLayerRec& rec, SaveLayerStrategy stra

* Perhaps in the future we could augment #5 to apply REMAINDER as part of the draw (no longer

* a sprite operation) to avoid the extra buffer/overhead of MatrixImageFilter.

- if (imageFilter && !stashedMatrix.isScaleTranslate() && !imageFilter->canHandleAffine() &&

+ if (imageFilter && !stashedMatrix.isScaleTranslate() && !imageFilter->canHandleComplexCTM() &&

stashedMatrix.decomposeScale(&scale, &remainder))

{

// We will restore the matrix (which we are overwriting here) in restore via fStashedMatrix

« no previous file with comments | « include/effects/SkMergeImageFilter.h ('k') | src/core/SkImageFilter.cpp » ('j') | no next file with comments »