include/effects/SkColorFilterImageFilter.h - Issue 1915943002: simplify handle-affine: subclass overrides just describe their leaf behavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/effects/SkColorFilterImageFilter.h

Issue 1915943002: simplify handle-affine: subclass overrides just describe their leaf behavior (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: early out if onCanHandleComplexCTM returns false Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/effects/SkColorFilterImageFilter.h

diff --git a/include/effects/SkColorFilterImageFilter.h b/include/effects/SkColorFilterImageFilter.h

index 10e1ffafa3413d067dcdf9c560b22ecfd30d8a5d..4d438e351972fc8aba30a1494eb445b4a8be2e38 100644

--- a/include/effects/SkColorFilterImageFilter.h

+++ b/include/effects/SkColorFilterImageFilter.h

@@ -36,7 +36,7 @@ protected:

sk_sp<SkSpecialImage> onFilterImage(SkSpecialImage* source, const Context&,

SkIPoint* offset) const override;

bool onIsColorFilterNode(SkColorFilter**) const override;

- bool onCanHandleAffine() const override;

+ bool onCanHandleComplexCTM() const override { return true; }

bool affectsTransparentBlack() const override;

private:

« no previous file with comments | « include/core/SkImageFilter.h ('k') | include/effects/SkComposeImageFilter.h » ('j') | no next file with comments »