Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: tests/ImageFilterTest.cpp

Issue 1915943002: simplify handle-affine: subclass overrides just describe their leaf behavior (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: early out if onCanHandleComplexCTM returns false Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/effects/SkColorFilterImageFilter.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkBitmap.h" 8 #include "SkBitmap.h"
9 #include "SkBlurImageFilter.h" 9 #include "SkBlurImageFilter.h"
10 #include "SkCanvas.h" 10 #include "SkCanvas.h"
(...skipping 1693 matching lines...) Expand 10 before | Expand all | Expand 10 after
1704 auto surface(SkSurface::MakeRenderTarget(ctxInfo.fGrContext, SkBudgeted::kYe s, 1704 auto surface(SkSurface::MakeRenderTarget(ctxInfo.fGrContext, SkBudgeted::kYe s,
1705 SkImageInfo::MakeN32Premul(100, 100 ))); 1705 SkImageInfo::MakeN32Premul(100, 100 )));
1706 test_large_blur_input(reporter, surface->getCanvas()); 1706 test_large_blur_input(reporter, surface->getCanvas());
1707 } 1707 }
1708 #endif 1708 #endif
1709 1709
1710 /* 1710 /*
1711 * Test that colorfilterimagefilter does not require its CTM to be decomposed w hen it has more 1711 * Test that colorfilterimagefilter does not require its CTM to be decomposed w hen it has more
1712 * than just scale/translate, but that other filters do. 1712 * than just scale/translate, but that other filters do.
1713 */ 1713 */
1714 DEF_TEST(ImageFilterDecomposeCTM, reporter) { 1714 DEF_TEST(ImageFilterComplexCTM, reporter) {
1715 // just need a colorfilter to exercise the corresponding imagefilter 1715 // just need a colorfilter to exercise the corresponding imagefilter
1716 sk_sp<SkColorFilter> cf = SkColorFilter::MakeModeFilter(SK_ColorRED, SkXferm ode::kSrcATop_Mode); 1716 sk_sp<SkColorFilter> cf = SkColorFilter::MakeModeFilter(SK_ColorRED, SkXferm ode::kSrcATop_Mode);
1717 sk_sp<SkImageFilter> cfif = SkColorFilterImageFilter::Make(cf, nullptr); 1717 sk_sp<SkImageFilter> cfif = SkColorFilterImageFilter::Make(cf, nullptr); // can handle
1718 sk_sp<SkImageFilter> blif = SkBlurImageFilter::Make(3, 3, nullptr); 1718 sk_sp<SkImageFilter> blif = SkBlurImageFilter::Make(3, 3, nullptr); // cannot handle
1719 1719
1720 struct { 1720 struct {
1721 sk_sp<SkImageFilter> fFilter; 1721 sk_sp<SkImageFilter> fFilter;
1722 bool fExpectCanHandle; 1722 bool fExpectCanHandle;
1723 } recs[] = { 1723 } recs[] = {
1724 { cfif, true }, 1724 { cfif, true },
1725 { SkColorFilterImageFilter::Make(cf, cfif), true }, 1725 { SkColorFilterImageFilter::Make(cf, cfif), true },
1726 { SkMergeImageFilter::Make(cfif, cfif), true }, 1726 { SkMergeImageFilter::Make(cfif, cfif), true },
1727 { SkComposeImageFilter::Make(cfif, cfif), true },
1728
1727 { blif, false }, 1729 { blif, false },
1730 { SkBlurImageFilter::Make(3, 3, cfif), false },
1731 { SkColorFilterImageFilter::Make(cf, blif), false },
1728 { SkMergeImageFilter::Make(cfif, blif), false }, 1732 { SkMergeImageFilter::Make(cfif, blif), false },
1729 { SkColorFilterImageFilter::Make(cf, blif), false }, 1733 { SkComposeImageFilter::Make(blif, cfif), false },
1730 }; 1734 };
1731 1735
1732 for (const auto& rec : recs) { 1736 for (const auto& rec : recs) {
1733 const bool canHandle = rec.fFilter->canHandleAffine(); 1737 const bool canHandle = rec.fFilter->canHandleComplexCTM();
1734 REPORTER_ASSERT(reporter, canHandle == rec.fExpectCanHandle); 1738 REPORTER_ASSERT(reporter, canHandle == rec.fExpectCanHandle);
1735 } 1739 }
1736 } 1740 }
OLDNEW
« no previous file with comments | « src/effects/SkColorFilterImageFilter.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698