Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1915913002: Version 5.1.281.15 (cherry-pick) (Closed)

Created:
4 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 8 months ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.1
Target Ref:
refs/pending/branch-heads/5.1
Project:
v8
Visibility:
Public.

Description

Version 5.1.281.15 (cherry-pick) Merged 0714485cbb4ea72359ae9ec73f9fb6c825a933e1 Revert of [GN] Define USE_EABI_HARDFLOAT=1 when arm_float_abi=="hard". (patchset #1 id:1 of https://codereview.chromium.org/1839763003/ ) BUG=592660, 604422 LOG=N R=hablich@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/c12882a3a97f394f0beb5e716b62fef68db63b2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M BUILD.gn View 4 chunks +4 lines, -8 lines 0 comments Download
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
jochen (gone - plz use gerrit)
4 years, 8 months ago (2016-04-25 11:58:18 UTC) #1
jochen (gone - plz use gerrit)
Committed patchset #1 (id:1) manually as c12882a3a97f394f0beb5e716b62fef68db63b2f.
4 years, 8 months ago (2016-04-25 12:02:02 UTC) #3
Michael Hablich
4 years, 8 months ago (2016-04-25 12:18:07 UTC) #4
Message was sent while issue was closed.
On 2016/04/25 12:02:02, jochen wrote:
> Committed patchset #1 (id:1) manually as
> c12882a3a97f394f0beb5e716b62fef68db63b2f.

lgtm

Powered by Google App Engine
This is Rietveld 408576698