Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: ui/views/controls/label.cc

Issue 1915863004: Remove View::focusable() - Alternate approach. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/controls/styled_label.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/label.cc
diff --git a/ui/views/controls/label.cc b/ui/views/controls/label.cc
index 8d46029a8041d452e6a702a0e891fe843c6b2aba..a72c2c8bffb903ff46bdb003d171f6b5245880a9 100644
--- a/ui/views/controls/label.cc
+++ b/ui/views/controls/label.cc
@@ -213,7 +213,7 @@ base::string16 Label::GetDisplayTextForTesting() {
gfx::Insets Label::GetInsets() const {
gfx::Insets insets = View::GetInsets();
- if (focusable()) {
+ if (IsFocusable()) {
insets += gfx::Insets(kFocusBorderPadding, kFocusBorderPadding,
kFocusBorderPadding, kFocusBorderPadding);
}
@@ -333,6 +333,11 @@ bool Label::GetTooltipText(const gfx::Point& p, base::string16* tooltip) const {
void Label::OnEnabledChanged() {
RecalculateColors();
+
+ // If the label has become focusable now due to being enabled, GetInsets()
+ // will return a different value. Hence reset layout.
karandeepb 2016/04/27 23:53:17 I am not totally sure whether this is needed or no
+ if (IsFocusable())
+ ResetLayout();
}
std::unique_ptr<gfx::RenderText> Label::CreateRenderText(
@@ -397,6 +402,11 @@ void Label::OnDeviceScaleFactorChanged(float device_scale_factor) {
void Label::VisibilityChanged(View* starting_from, bool is_visible) {
if (!is_visible)
lines_.clear();
+
+ // If the label has become focusable now due to being visible, GetInsets()
+ // will return a different value. Hence reset layout.
+ if (IsFocusable())
+ ResetLayout();
}
void Label::Init(const base::string16& text, const gfx::FontList& font_list) {
@@ -435,7 +445,7 @@ void Label::MaybeBuildRenderTextLines() {
return;
gfx::Rect rect = GetContentsBounds();
- if (focusable())
+ if (IsFocusable())
rect.Inset(kFocusBorderPadding, kFocusBorderPadding);
if (rect.IsEmpty())
return;
« no previous file with comments | « no previous file | ui/views/controls/styled_label.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698