build/config/mac/rules.gni - Issue 1915863003: [Mac/GN] Build content_shell and content_shell_framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/mac/rules.gni

Issue 1915863003: [Mac/GN] Build content_shell and content_shell_framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-info-plist

Patch Set: Bot fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/mac/rules.gni

diff --git a/build/config/mac/rules.gni b/build/config/mac/rules.gni

index 9d13d8c4d69e1fa16a96578c02ba338ddbbd605e..34d5500ce34cac84cb65b10d0b62e6c2c308cc52 100644

--- a/build/config/mac/rules.gni

+++ b/build/config/mac/rules.gni

@@ -361,8 +361,10 @@ template("mac_xib_bundle_data") {

ibtool_flags = [

"--minimum-deployment-target",

mac_deployment_target,

- "--target-device",

- "mac",

+ # TODO(rsesek): Enable this once all the bots are on Xcode 7+.

+ # "--target-device",

+ # "mac",

]

}

« no previous file with comments | « no previous file | build/config/mac/xcrun.py » ('j') | content/shell/BUILD.gn » ('J')