tools/android/loading/request_track.py - Issue 1915853007: clovis: Failed requests have no timings, don't crash in the serialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/loading/request_track.py

Issue 1915853007: clovis: Failed requests have no timings, don't crash in the serialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/android/loading/request_track.py

diff --git a/tools/android/loading/request_track.py b/tools/android/loading/request_track.py

index 31eca5186010bdac568f22b3ed9c0e42734f41b4..b4e3a151c25894108c89fa8ecf9442519ac25752 100644

--- a/tools/android/loading/request_track.py

+++ b/tools/android/loading/request_track.py

@@ -220,7 +220,7 @@ class Request(object):

def ToJsonDict(self):

result = copy.deepcopy(self.__dict__)

- result['timing'] = self.timing.ToJsonDict()

+ result['timing'] = self.timing.ToJsonDict() if self.timing else {}

return result

@classmethod

« no previous file with comments | « no previous file | no next file » | no next file with comments »