Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1915853005: Revert of Switch Android Builder on chromium.webkit to gn. (Closed)

Created:
4 years, 8 months ago by jbudorick
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, agrieve
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Switch Android Builder on chromium.webkit to gn. (patchset #1 id:1 of https://codereview.chromium.org/1902643003/ ) Reason for revert: too many gn issues. Original issue's description: > Switch Android Builder on chromium.webkit to gn. > > BUG=604468 > > Committed: https://crrev.com/16d24abd98d2b5c87d2065ae29d27ea98ac92e51 > Cr-Commit-Position: refs/heads/master@{#388383} TBR=dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=604468 Committed: https://crrev.com/0596520e084755c8deb81249f39694abd5ccdf04 Cr-Commit-Position: refs/heads/master@{#389622}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M tools/mb/mb_config.pyl View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
jbudorick
Created Revert of Switch Android Builder on chromium.webkit to gn.
4 years, 8 months ago (2016-04-25 21:16:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915853005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915853005/1
4 years, 8 months ago (2016-04-25 21:16:52 UTC) #2
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-25 21:20:04 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn/builds/24720)
4 years, 8 months ago (2016-04-25 21:21:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915853005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915853005/40001
4 years, 8 months ago (2016-04-25 21:33:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-04-25 23:35:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915853005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915853005/40001
4 years, 8 months ago (2016-04-25 23:36:46 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-04-25 23:58:14 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 23:59:18 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0596520e084755c8deb81249f39694abd5ccdf04
Cr-Commit-Position: refs/heads/master@{#389622}

Powered by Google App Engine
This is Rietveld 408576698