Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: tools/testing/dart/runtime_configuration.dart

Issue 1915853004: Option to output precompiled instructions as a blob for use with mmap instead of assembly for use i… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/runtime_configuration.dart
diff --git a/tools/testing/dart/runtime_configuration.dart b/tools/testing/dart/runtime_configuration.dart
index 867d8f7c7ba3d189a41749f053893e2bcc794c20..71913427ccdc30dd2f90a7c9dc897087a4aae1b5 100644
--- a/tools/testing/dart/runtime_configuration.dart
+++ b/tools/testing/dart/runtime_configuration.dart
@@ -19,6 +19,8 @@ class RuntimeConfiguration {
// [RuntimeConfiguration] in [configuration] there.
factory RuntimeConfiguration(Map configuration) {
String runtime = configuration['runtime'];
+ bool useBlobs = configuration['use_blobs'];
+
switch (runtime) {
case 'ContentShellOnAndroid':
case 'DartiumOnAndroid':
@@ -52,7 +54,7 @@ class RuntimeConfiguration {
return new DartProductRuntimeConfiguration();
case 'dart_precompiled':
- return new DartPrecompiledRuntimeConfiguration();
+ return new DartPrecompiledRuntimeConfiguration(useBlobs: useBlobs);
case 'drt':
return new DrtRuntimeConfiguration();
@@ -244,6 +246,9 @@ class DartProductRuntimeConfiguration extends DartVmRuntimeConfiguration {
}
class DartPrecompiledRuntimeConfiguration extends DartVmRuntimeConfiguration {
+ final bool useBlobs;
+ DartPrecompiledRuntimeConfiguration({bool useBlobs}) : useBlobs = useBlobs;
+
List<Command> computeRuntimeCommands(
TestSuite suite,
CommandBuilder commandBuilder,
@@ -258,6 +263,9 @@ class DartPrecompiledRuntimeConfiguration extends DartVmRuntimeConfiguration {
var augmentedArgs = new List();
augmentedArgs.add("--run-precompiled-snapshot=${artifact.filename}");
+ if (useBlobs) {
+ augmentedArgs.add("--use_blobs");
+ }
augmentedArgs.addAll(arguments);
return <Command>[
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698