Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1915853002: Revert of Provide capability classes from Mus (Closed)

Created:
4 years, 8 months ago by Marc Treib
Modified:
4 years, 8 months ago
CC:
chromium-reviews, rjkroege, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Provide capability classes from Mus (patchset #8 id:140001 of https://codereview.chromium.org/1910043002/ ) Reason for revert: Speculative revert: Seems to have broken mash_unittests on Linux ChromiumOS GN: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/38372 Original issue's description: > Provide capability classes from Mus > > - Allow mus to reject connections from sources that do not specify a class. > > R=sky@chromium.org > BUG= > > Committed: https://crrev.com/d566fafb3c810da8267e5a7f54420cd9c05c950e > Cr-Commit-Position: refs/heads/master@{#389310} TBR=sky@chromium.org,ben@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/38a95d6a3a939f868819bd0902711ed42dffaf2d Cr-Commit-Position: refs/heads/master@{#389434}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -203 lines) Patch
M ash/mus/manifest.json View 1 chunk +1 line, -7 lines 0 comments Download
M components/mus/demo/manifest.json View 1 chunk +1 line, -7 lines 0 comments Download
M components/mus/manifest.json View 1 chunk +2 lines, -20 lines 0 comments Download
M components/mus/ws/mus_ws_unittests_app_manifest.json View 1 chunk +1 line, -10 lines 0 comments Download
M components/resource_provider/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 chunk +1 line, -5 lines 0 comments Download
M content/public/app/mojo/content_renderer_manifest.json View 1 chunk +1 line, -6 lines 0 comments Download
M mash/catalog_viewer/manifest.json View 1 chunk +2 lines, -5 lines 0 comments Download
M mash/example/views_examples/manifest.json View 1 chunk +2 lines, -5 lines 0 comments Download
M mash/example/window_type_launcher/manifest.json View 1 chunk +1 line, -8 lines 0 comments Download
M mash/init/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M mash/login/manifest.json View 1 chunk +1 line, -2 lines 0 comments Download
M mash/quick_launch/manifest.json View 1 chunk +2 lines, -5 lines 0 comments Download
M mash/quick_launch/quick_launch_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/screenlock/manifest.json View 1 chunk +1 line, -7 lines 0 comments Download
M mash/task_viewer/manifest.json View 1 chunk +2 lines, -5 lines 0 comments Download
M mash/unittests_manifest.json View 1 chunk +1 line, -11 lines 0 comments Download
M mash/wm/manifest.json View 1 chunk +1 line, -7 lines 0 comments Download
M services/catalog/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/manifest.json View 1 chunk +5 lines, -6 lines 0 comments Download
M services/shell/public/cpp/lib/interface_registry.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M services/shell/shell.cc View 2 chunks +8 lines, -18 lines 0 comments Download
M services/shell/tests/connect/connect_test_app_a_manifest.json View 1 chunk +1 line, -5 lines 0 comments Download
M services/shell/tests/connect/connect_test_app_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/connect/connect_test_class_app.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/shell/tests/connect/connect_test_class_app_manifest.json View 1 chunk +1 line, -4 lines 0 comments Download
M services/shell/tests/connect/connect_test_singleton_app_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/connect/connect_unittest.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M services/shell/tests/connect/connect_unittests_manifest.json View 2 chunks +1 line, -4 lines 0 comments Download
M services/shell/tests/lifecycle/lifecycle_unittest_manifest.json View 1 chunk +2 lines, -4 lines 0 comments Download
M services/shell/tests/shell/driver_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/tracing/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/BUILD.gn View 3 chunks +0 lines, -8 lines 0 comments Download
M ui/views/mus/platform_test_helper_mus.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M ui/views/mus/screen_mus_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/views/mus/unittests_manifest.json View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Marc Treib
Created Revert of Provide capability classes from Mus
4 years, 8 months ago (2016-04-25 08:09:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915853002/1
4 years, 8 months ago (2016-04-25 08:09:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915853002/1
4 years, 8 months ago (2016-04-25 08:31:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915853002/1
4 years, 8 months ago (2016-04-25 09:01:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 09:10:13 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 09:11:52 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/38a95d6a3a939f868819bd0902711ed42dffaf2d
Cr-Commit-Position: refs/heads/master@{#389434}

Powered by Google App Engine
This is Rietveld 408576698