Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1915833004:
Flip all remaining Linux x86 (32-bit) bots to GN. (Closed)
|
Created:
4 years, 8 months ago by Dirk Pranke Modified:
4 years, 8 months ago Reviewers:
brettw CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFlip all remaining Linux x86 (32-bit) bots to GN.
R=brettw@chromium.org
BUG=605732
Committed: https://crrev.com/b90dc23f793b456b053666ae2d65d2efa4fac20b
Cr-Commit-Position: refs/heads/master@{#389949}
Patch Set 1 #Patch Set 2 : merge #Patch Set 3 : merge #Messages
Total messages: 18 (8 generated)
This patch depends on https://codereview.chromium.org/1917883003/ having landed first so that the bots will not use a 32-bit python instance and get confused.
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915833004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915833004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
lgtm
The CQ bit was checked by dpranke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org Link to the patchset: https://codereview.chromium.org/1915833004/#ps20001 (title: "merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915833004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915833004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by dpranke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org Link to the patchset: https://codereview.chromium.org/1915833004/#ps40001 (title: "merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915833004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915833004/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Flip all remaining Linux x86 (32-bit) bots to GN. R=brettw@chromium.org BUG=605732 ========== to ========== Flip all remaining Linux x86 (32-bit) bots to GN. R=brettw@chromium.org BUG=605732 Committed: https://crrev.com/b90dc23f793b456b053666ae2d65d2efa4fac20b Cr-Commit-Position: refs/heads/master@{#389949} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/b90dc23f793b456b053666ae2d65d2efa4fac20b Cr-Commit-Position: refs/heads/master@{#389949}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1924733002/ by dpranke@chromium.org. The reason for reverting is: looks like we might have some compile failures to fix: https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg.... |
