Introduce Platform::cacheMetadataInCacheStorage() to store V8 code cache in CacheStorage

third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

Index: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
index 7470f70ed4c369bbb5e8a967e1a2111ba902aa15..8d0acb27a555e6be7b2a6c6fec9184d7163eff9f 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
@@ -131,6 +131,20 @@ v8::Local<v8::Value> ScriptController::executeScriptAndReturnValue(v8::Local<v8:
         V8CacheOptions v8CacheOptions(V8CacheOptionsDefault);
         if (frame()->settings())
             v8CacheOptions = frame()->settings()->v8CacheOptions();
+        if (source.resource() && !source.resource()->response().cacheStorageCacheName().isNull()) {

[vogelheim, 2016/05/03 11:36:05]

patch set #2 implemented this so that the ServiceWorker app-cahce would use the
code cache if V8CacheOptions was V8CacheOptionsCode (or *Default) AND
V8CacheStrategiesForCacheStorage were Normal or Aggressive. With this setting,
V8CacheStrategiesForCacheStorage is independent of V8CacheOptions.

Either is fine; please pick as you see fit. I just can't tell whether this is an
intentional change or not. :)

+            switch (frame()->settings()->v8CacheStrategiesForCacheStorage()) {
+            case V8CacheStrategiesForCacheStorage::Default:
+            case V8CacheStrategiesForCacheStorage::None:
+                v8CacheOptions = V8CacheOptionsNone;
+                break;
+            case V8CacheStrategiesForCacheStorage::Normal:
+                v8CacheOptions = V8CacheOptionsDefault;

[vogelheim, 2016/05/03 11:36:05]

V8CacheOptionsCode?

(Loosely related to the previous comment: *Default is (currently) the same as
*Code, but the idea is that *Default can be changed if we change the default,
while *Code describes a specific behaviour.)

[horo, 2016/05/09 04:00:04]

Yes.
I think V8CacheStrategiesForCacheStorage should be independent of
V8CacheOptions.
So I changed it to V8CacheOptionsCode.

+                break;
+            case V8CacheStrategiesForCacheStorage::Aggressive:
+                v8CacheOptions = V8CacheOptionsAlways;
+                break;
+            }
+        }
 
         // Isolate exceptions that occur when compiling and executing
         // the code. These exceptions should not interfere with