third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp - Issue 1915833002: Introduce Platform::cacheMetadataInCacheStorage() to store V8 code cache in CacheStorage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 1915833002: Introduce Platform::cacheMetadataInCacheStorage() to store V8 code cache in CacheStorage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8CacheStrategiesForCacheStorage.h ('K') | « third_party/WebKit/Source/bindings/core/v8/V8CacheStrategiesForCacheStorage.h ('k') | third_party/WebKit/Source/bindings/core/v8/v8.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

index 6eb2f137f27a4ac94ec4d790f2321ec1fce2df7e..3be42bfd496834225f640ff98b946807799b2503 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

@@ -302,7 +302,7 @@ PassOwnPtr<CompileFn> selectCompileFunction(V8CacheOptions cacheOptions, CachedM

CachedMetadata* codeCache = cacheHandler->cachedMetadata(codeCacheTag);

if (codeCache)

return bind(compileAndConsumeCache, cacheHandler, codeCacheTag, v8::ScriptCompiler::kConsumeCodeCache);

- if (!isResourceHotForCaching(cacheHandler, hotHours)) {

+ if (!cacheHandler->shouldAggressivelyCache() && !isResourceHotForCaching(cacheHandler, hotHours)) {

V8ScriptRunner::setCacheTimeStamp(cacheHandler);

return bind(compileWithoutOptions, V8CompileHistogram::Cacheable);

}