third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp - Issue 1915833002: Introduce Platform::cacheMetadataInCacheStorage() to store V8 code cache in CacheStorage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

Issue 1915833002: Introduce Platform::cacheMetadataInCacheStorage() to store V8 code cache in CacheStorage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments in render_process_messages.h Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_message_filter.cc ('K') | « third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8CacheOptions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

index 94bb106cede79388baf860788d27fae901f18d82..7e413e8ec6ad9b42ca485161b84a8bdf497ce7b0 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

@@ -279,6 +279,12 @@ private:

// BOM can only occur at the beginning of the data.

ASSERT(lengthOfBOM == 0 || m_queueTailPosition == 0);

+ if (!streamer->resource()->response().cacheStorageCacheName().isNull()) {

+ streamer->suppressStreaming();

+ cancel();

+ return;

+ }

CachedMetadataHandler* cacheHandler = streamer->resource()->cacheHandler();

if (cacheHandler && cacheHandler->cachedMetadata(V8ScriptRunner::tagForCodeCache(cacheHandler))) {

// The resource has a code cache, so it's unnecessary to stream and