device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.cc - Issue 1915803002: Bluetooth class changes for implementing local GATT attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.cc

Issue 1915803002: Bluetooth class changes for implementing local GATT attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: magic values fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/bluez/bluetooth_local_gatt_characteristic_bluez.cc ('K') | « device/bluetooth/bluez/bluetooth_local_gatt_service_bluez.cc ('k') | device/bluetooth/bluez/bluetooth_remote_gatt_descriptor_bluez.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.cc

diff --git a/device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.cc b/device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.cc

index b1d6a0ef80fae257db6831d27233915019a03b52..b33268d41c64a51830bb465e3c340dd0db188115 100644

--- a/device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.cc

+++ b/device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.cc

@@ -42,11 +42,11 @@ std::ostream& operator<<(std::ostream& out, const std::vector<uint8_t> bytes) {

BluetoothRemoteGattCharacteristicBlueZ::BluetoothRemoteGattCharacteristicBlueZ(

BluetoothRemoteGattServiceBlueZ* service,

const dbus::ObjectPath& object_path)

- : BluetoothGattCharacteristicBlueZ(object_path),

- num_notify_sessions_(0),

+ : num_notify_sessions_(0),

notify_call_pending_(false),

service_(service),

weak_ptr_factory_(this) {

+ object_path_ = object_path;

VLOG(1) << "Creating remote GATT characteristic with identifier: "

<< GetIdentifier() << ", UUID: " << GetUUID().canonical_value();

bluez::BluezDBusManager::Get()