device/bluetooth/bluetooth_gatt_service.h - Issue 1915803002: Bluetooth class changes for implementing local GATT attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_gatt_service.h

Issue 1915803002: Bluetooth class changes for implementing local GATT attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: magic values fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/bluetooth.gyp ('k') | device/bluetooth/bluetooth_local_gatt_characteristic.h » ('j') | device/bluetooth/bluetooth_local_gatt_characteristic.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_gatt_service.h

diff --git a/device/bluetooth/bluetooth_gatt_service.h b/device/bluetooth/bluetooth_gatt_service.h

index 7e78b2bdd0aa761d4df2d14b03a6a4d302d922b8..01176a6bb92090b3978463337d7c2271dd2fc0b5 100644

--- a/device/bluetooth/bluetooth_gatt_service.h

+++ b/device/bluetooth/bluetooth_gatt_service.h

@@ -22,6 +22,7 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothGattService {

public:

// Interacting with Characteristics and Descriptors can produce

// this set of errors.

+ // TODO(rkc): Update this list.

scheib 2016/04/26 06:03:32 If a following patch updates this, link the patch.

rkc 2016/04/26 18:23:59 The comment is outdated. This list is pretty compr

enum GattErrorCode {

GATT_ERROR_UNKNOWN = 0,

GATT_ERROR_FAILED,