Bluetooth class changes for implementing local GATT attributes.

device/bluetooth/bluez/bluetooth_gatt_characteristic_bluez.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_BLUETOOTH_BLUEZ_BLUETOOTH_GATT_CHARACTERISTIC_BLUEZ_H_
 #define DEVICE_BLUETOOTH_BLUEZ_BLUETOOTH_GATT_CHARACTERISTIC_BLUEZ_H_
 
 #include <string>
 
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "dbus/object_path.h"
 #include "device/bluetooth/bluetooth_gatt_characteristic.h"
 
 namespace bluez {
 
 // The BluetoothGattCharacteristicBlueZ class implements
 // BluetoothRemoteGattCharacteristic for GATT characteristics for platforms
 // that use BlueZ.
 class BluetoothGattCharacteristicBlueZ
     : public virtual device::BluetoothGattCharacteristic {
  public:
   // device::BluetoothGattCharacteristic overrides.
   std::string GetIdentifier() const override;
 
   // Object path of the underlying D-Bus characteristic.
   const dbus::ObjectPath& object_path() const { return object_path_; }
 
  protected:
-  explicit BluetoothGattCharacteristicBlueZ(
-      const dbus::ObjectPath& object_path);
+  BluetoothGattCharacteristicBlueZ();

[scheib, 2016/04/28 01:06:24]

I mentioned in the earlier patch (before splitting to this) that it seems odd to
move the members that are assigned during construction up to be protected. At
the time I suggested having virtual implementations of e.g. object_path.

You argued against virtual impl of the accessors, which is OK. But, I still
don't like the uncertain constructed state of these members.

object_path_ can remain a constructor argument and the member can be initialized
programmatically in the constructor initializer list. E.g. below 
  object_path_(BluetoothLocalGattServiceBlueZ::AddGuidToObjectPath(
    service->object_path().value() + "/characteristic"))

This makes it clear in the BluetoothGattCharacteristicBlueZ declaration that
object_path_ will always be set upon construction by any subclass.

[rkc, 2016/04/28 02:06:57]

Done.

   ~BluetoothGattCharacteristicBlueZ() override;
 
- private:
   // Object path of the D-Bus characteristic object.
   dbus::ObjectPath object_path_;
 
+ private:
   // Note: This should remain the last member so it'll be destroyed and
   // invalidate its weak pointers before any other members are destroyed.
   base::WeakPtrFactory<BluetoothGattCharacteristicBlueZ> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BluetoothGattCharacteristicBlueZ);
 };
 
 }  // namespace bluez
 
 #endif  // DEVICE_BLUETOOTH_BLUEZ_BLUETOOTH_GATT_CHARACTERISTIC_BLUEZ_H_