Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: third_party/WebKit/Source/core/frame/FrameHost.cpp

Issue 1915783002: Move overscroll logic out of EventHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make m_visualViewport a WeakMember Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameHost.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameHost.cpp b/third_party/WebKit/Source/core/frame/FrameHost.cpp
index cf736ea33dd8bb65983927413a0da8a709e9915f..442e779ed57250755dc9df070f9bf202f1855ff9 100644
--- a/third_party/WebKit/Source/core/frame/FrameHost.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameHost.cpp
@@ -35,6 +35,7 @@
#include "core/frame/TopControls.h"
#include "core/inspector/ConsoleMessageStorage.h"
#include "core/page/Page.h"
+#include "core/page/scrolling/OverscrollController.h"
#include "public/platform/Platform.h"
#include "public/platform/WebScheduler.h"
@@ -50,6 +51,9 @@ FrameHost::FrameHost(Page& page)
, m_topControls(TopControls::create(*this))
, m_pageScaleConstraintsSet(PageScaleConstraintsSet::create())
, m_visualViewport(VisualViewport::create(*this))
+ , m_overscrollController(OverscrollController::create(
+ *m_visualViewport,
+ m_page->chromeClient()))
, m_eventHandlerRegistry(new EventHandlerRegistry(*this))
, m_consoleMessageStorage(ConsoleMessageStorage::create())
, m_subframeCount(0)
@@ -91,6 +95,11 @@ TopControls& FrameHost::topControls() const
return *m_topControls;
}
+OverscrollController& FrameHost::overscrollController() const
+{
+ return *m_overscrollController;
+}
+
VisualViewport& FrameHost::visualViewport() const
{
return *m_visualViewport;
@@ -116,6 +125,7 @@ DEFINE_TRACE(FrameHost)
visitor->trace(m_page);
visitor->trace(m_topControls);
visitor->trace(m_visualViewport);
+ visitor->trace(m_overscrollController);
visitor->trace(m_eventHandlerRegistry);
visitor->trace(m_consoleMessageStorage);
}

Powered by Google App Engine
This is Rietveld 408576698