extensions/renderer/safe_builtins.cc - Issue 1915753002: Sanitize inheritance in callers of utils.expose

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/safe_builtins.cc

Issue 1915753002: Sanitize inheritance in callers of utils.expose (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: webview: Set proto on prototype. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/safe_builtins.cc

diff --git a/extensions/renderer/safe_builtins.cc b/extensions/renderer/safe_builtins.cc

index f86d92f8583802ce0113820e25168b93eb9d36b9..c079b4038ec285673a4c44e3df1cb7a2aa1ab1d7 100644

--- a/extensions/renderer/safe_builtins.cc

+++ b/extensions/renderer/safe_builtins.cc

@@ -76,7 +76,7 @@ const char kScript[] =

" ['apply', 'bind', 'call']);\n"

"saveBuiltin(Array,\n"

" ['concat', 'forEach', 'indexOf', 'join', 'push', 'slice',\n"

- " 'splice', 'map', 'filter', 'unshift'],\n"

+ " 'splice', 'map', 'filter', 'unshift', 'pop', 'reverse'],\n"

" ['isArray']);\n"

"saveBuiltin(String,\n"

" ['indexOf', 'slice', 'split', 'substr', 'toUpperCase',\n"