extensions/renderer/resources/utils.js - Issue 1915753002: Sanitize inheritance in callers of utils.expose

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/utils.js

Issue 1915753002: Sanitize inheritance in callers of utils.expose (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: webview: Set proto on prototype. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/resources/utils.js

diff --git a/extensions/renderer/resources/utils.js b/extensions/renderer/resources/utils.js

index fd70c603ddffe295c6dc31d8efe495ca82c0760b..890e13cbfda1f7c3254fb84a845f8170af55ebcd 100644

--- a/extensions/renderer/resources/utils.js

+++ b/extensions/renderer/resources/utils.js

@@ -90,8 +90,7 @@ function loadTypeSchema(typeName, defaultSchema) {

* properties and |readonly| are read-only properties.

function expose(publicClass, privateClass, exposed) {

- // TODO(robwu): Fix callers and uncomment this assertion.

- // DCHECK(!(privateClass instanceof $Object.self));

+ DCHECK(!(privateClass instanceof $Object.self));

$Object.setPrototypeOf(exposed, null);