Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1915683002: Export only Cronet API symbols and hide all others. (Closed)

Created:
4 years, 8 months ago by kapishnikov
Modified:
4 years, 7 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Export only Cronet API symbols and hide all others. BUG=601972 Committed: https://crrev.com/cc58c0d6f8f5319ba8bb5b5535e3c56f4b571397 Cr-Commit-Position: refs/heads/master@{#389874}

Patch Set 1 #

Patch Set 2 : Canceled auto-formatting #

Total comments: 1

Patch Set 3 : Defined CRONET_EXPORT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M components/cronet.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/cronet/ios/Cronet.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/cronet/ios/cronet_c_for_grpc.h View 1 2 7 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
kapishnikov
4 years, 8 months ago (2016-04-22 21:42:02 UTC) #2
mef
https://codereview.chromium.org/1915683002/diff/20001/components/cronet/ios/Cronet.h File components/cronet/ios/Cronet.h (right): https://codereview.chromium.org/1915683002/diff/20001/components/cronet/ios/Cronet.h#newcode10 components/cronet/ios/Cronet.h:10: __attribute__((visibility("default"))) can we make it a define like CRONET_EXPORT ...
4 years, 8 months ago (2016-04-25 12:45:42 UTC) #3
kapishnikov
On 2016/04/25 12:45:42, mef wrote: > https://codereview.chromium.org/1915683002/diff/20001/components/cronet/ios/Cronet.h > File components/cronet/ios/Cronet.h (right): > > https://codereview.chromium.org/1915683002/diff/20001/components/cronet/ios/Cronet.h#newcode10 > ...
4 years, 8 months ago (2016-04-25 19:12:59 UTC) #4
mef
lgtm
4 years, 7 months ago (2016-04-26 19:02:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915683002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915683002/40001
4 years, 7 months ago (2016-04-26 19:03:26 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-26 20:27:33 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 20:30:05 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/cc58c0d6f8f5319ba8bb5b5535e3c56f4b571397
Cr-Commit-Position: refs/heads/master@{#389874}

Powered by Google App Engine
This is Rietveld 408576698