Turn on compositing for animations with software compositor.

Turn on compositing for animations with software compositor.

R=jbauman@chromium.org, piman@chromium.org, jbauman, piman
BUG=350141
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255962

[jbauman, 2014-03-07 22:59:29]

lgtm with one thing fixed.

https://codereview.chromium.org/191563003/diff/1/content/browser/gpu/gpu_data...
File content/browser/gpu/gpu_data_manager_impl_private.cc (right):

https://codereview.chromium.org/191563003/diff/1/content/browser/gpu/gpu_data...
content/browser/gpu/gpu_data_manager_impl_private.cc:790:
prefs->accelerated_compositing_for_animation_enabled = false;
This line is redundant with the one above.

[danakj, 2014-03-07 23:02:36]

https://codereview.chromium.org/191563003/diff/1/content/browser/gpu/gpu_data...
File content/browser/gpu/gpu_data_manager_impl_private.cc (right):

https://codereview.chromium.org/191563003/diff/1/content/browser/gpu/gpu_data...
content/browser/gpu/gpu_data_manager_impl_private.cc:790:
prefs->accelerated_compositing_for_animation_enabled = false;
On 2014/03/07 22:59:29, jbauman wrote:
> This line is redundant with the one above.

Oh, I was mimicing line 779. Should we just always have it set to true then?

[jbauman, 2014-03-07 23:09:44]

https://codereview.chromium.org/191563003/diff/1/content/browser/gpu/gpu_data...
File content/browser/gpu/gpu_data_manager_impl_private.cc (right):

https://codereview.chromium.org/191563003/diff/1/content/browser/gpu/gpu_data...
content/browser/gpu/gpu_data_manager_impl_private.cc:790:
prefs->accelerated_compositing_for_animation_enabled = false;
On 2014/03/07 23:02:36, danakj wrote:
> On 2014/03/07 22:59:29, jbauman wrote:
> > This line is redundant with the one above.
> 
> Oh, I was mimicing line 779. Should we just always have it set to true then?

I mean, this is literally a duplicate of line 788.

[danakj, 2014-03-07 23:11:11]

https://codereview.chromium.org/191563003/diff/1/content/browser/gpu/gpu_data...
File content/browser/gpu/gpu_data_manager_impl_private.cc (right):

https://codereview.chromium.org/191563003/diff/1/content/browser/gpu/gpu_data...
content/browser/gpu/gpu_data_manager_impl_private.cc:790:
prefs->accelerated_compositing_for_animation_enabled = false;
On 2014/03/07 23:09:44, jbauman wrote:
> On 2014/03/07 23:02:36, danakj wrote:
> > On 2014/03/07 22:59:29, jbauman wrote:
> > > This line is redundant with the one above.
> > 
> > Oh, I was mimicing line 779. Should we just always have it set to true then?
> 
> I mean, this is literally a duplicate of line 788.

Ohhh, order changed. :D thanks!

[danakj, 2014-03-07 23:12:28]

piman: PTAL for OWNERS

[piman, 2014-03-07 23:25:07]

LGTM. I can't wait until those flags are gone.

[danakj, 2014-03-07 23:25:59]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-03-07 23:27:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/191563003/40001

[commit-bot: I haz the power, 2014-03-08 11:09:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/191563003/40001

[commit-bot: I haz the power, 2014-03-08 13:50:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-08 13:50:03]

Retried try job too often on mac_rel for step(s) telemetry_perf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[danakj, 2014-03-10 17:37:22]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-03-10 17:37:39]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2014-03-10 17:38:23]

Committed patchset #2 manually as r255962 (presubmit successful).