Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Issue 1915623002: Fixed DevTools event-listener breakpoints for PointerEvents. (Closed)

Created:
4 years, 8 months ago by mustaq
Modified:
4 years, 7 months ago
Reviewers:
kozy, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed DevTools event-listener breakpoints for PointerEvents. Also added a test with PointerEvent specific expectation, in the "pointerevent" virtual suite. BUG=605706 Committed: https://crrev.com/2ce75f46df1069cd68a30be5a1298f21c7774f60 Cr-Commit-Position: refs/heads/master@{#390988}

Patch Set 1 #

Patch Set 2 : Added a test. #

Patch Set 3 : #

Messages

Total messages: 23 (9 generated)
mustaq
ptal
4 years, 8 months ago (2016-04-22 19:17:09 UTC) #2
kozy
Can we add a test? Example of test: blink/tools/run_layout_tests.py inspector/sources/debugger-breakpoints/event-listener-breakpoints.html
4 years, 8 months ago (2016-04-22 21:38:20 UTC) #3
mustaq
On 2016/04/22 21:38:20, kozyatinskiy wrote: > Can we add a test? > Example of test: ...
4 years, 8 months ago (2016-04-26 17:34:23 UTC) #5
kozy
lgtm
4 years, 7 months ago (2016-04-29 01:59:16 UTC) #6
kozy
Andrey, could you please take a look?
4 years, 7 months ago (2016-04-29 01:59:54 UTC) #8
lushnikov
nice, thanks!
4 years, 7 months ago (2016-04-29 03:51:16 UTC) #9
lushnikov
lgtm
4 years, 7 months ago (2016-04-29 03:51:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915623002/20001
4 years, 7 months ago (2016-04-29 13:43:02 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/221271)
4 years, 7 months ago (2016-04-29 16:03:05 UTC) #14
mustaq
On 2016/04/29 16:03:05, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 7 months ago (2016-05-02 15:20:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915623002/40001
4 years, 7 months ago (2016-05-02 15:21:01 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-02 17:53:44 UTC) #20
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/2ce75f46df1069cd68a30be5a1298f21c7774f60 Cr-Commit-Position: refs/heads/master@{#390988}
4 years, 7 months ago (2016-05-02 17:55:34 UTC) #22
Dirk Pranke
4 years, 7 months ago (2016-05-03 00:11:26 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1935373002/ by dpranke@chromium.org.

The reason for reverting is: Reverting this, one of the tests is timing out in
debug builds:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28....

Powered by Google App Engine
This is Rietveld 408576698