Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1915593003: Reland of Add function to trace stack using frame pointers. (Closed)

Created:
4 years, 8 months ago by Dmitry Skiba
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add function to trace stack using frame pointers. Original CL (1879073002) was reverted because it triggered several use-of-uninitialized-value errors on Linux ChromeOS MSan bot. See crbug.com/602701#c6 for details. Those errors are expected because reading values from the stack outside of the function's frame is essential to the process of unwinding. This CL adds change to disable the unit test if MEMORY_SANITIZER is defined. Additionally, this CL fixes unwinding on ARM by moving sp adjustment several lines up. Original issue's description: > For memory-infra we need fast stack traces to implement allocation > tracing (see https://goo.gl/DFoqfi). StackTrace class uses unwinding > and is too slow. This change adds a function that uses frame pointers > to walk the stack. > > The function supports x86, x64 and arm (but not thumb) architectures > on POSIX platforms. BUG=602701 Committed: https://crrev.com/79080da0203790b2e12ab36ab50f8a374aea8455 Cr-Commit-Position: refs/heads/master@{#389320}

Patch Set 1 : Original CL #

Patch Set 2 : Disable the unit test on MSan #

Patch Set 3 : Fix ARM unwinding on GCC #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -0 lines) Patch
M base/debug/stack_trace.h View 2 chunks +22 lines, -0 lines 0 comments Download
M base/debug/stack_trace.cc View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
M base/debug/stack_trace_unittest.cc View 1 1 chunk +51 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Dmitry Skiba
Guys, please review. (This is what you get when you aggressively land un-LGTM'ed changes... MSan ...
4 years, 8 months ago (2016-04-22 18:48:23 UTC) #3
Nico
lgtm
4 years, 8 months ago (2016-04-22 20:03:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915593003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915593003/40001
4 years, 8 months ago (2016-04-22 22:56:26 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-23 00:10:36 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-23 00:12:40 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/79080da0203790b2e12ab36ab50f8a374aea8455
Cr-Commit-Position: refs/heads/master@{#389320}

Powered by Google App Engine
This is Rietveld 408576698