Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1915563002: Default VDA expected coded size to 320x240. (Closed)

Created:
4 years, 8 months ago by liberato (no reviews please)
Modified:
4 years, 8 months ago
Reviewers:
watk, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Default VDA expected coded size to 320x240. Provide a default of 320x240 as the expected coded size when initializing VDA::Config. This was the default prior to https://codereview.chromium.org/1869103002 , but switched to 0x0 by that change. Any user of VDA except GpuVideoDecoder will use the default. BUG=602759 Committed: https://crrev.com/99ddcd4719b569522b5effad17de2125120ecd89 Cr-Commit-Position: refs/heads/master@{#389228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/video/video_decode_accelerator.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
watk
lgtm
4 years, 8 months ago (2016-04-22 20:12:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915563002/1
4 years, 8 months ago (2016-04-22 20:32:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 20:39:54 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/99ddcd4719b569522b5effad17de2125120ecd89 Cr-Commit-Position: refs/heads/master@{#389228}
4 years, 8 months ago (2016-04-22 20:41:19 UTC) #9
DaleCurtis
Don't you always overwrite this value?
4 years, 8 months ago (2016-04-22 21:58:20 UTC) #11
DaleCurtis
4 years, 8 months ago (2016-04-22 21:59:10 UTC) #12
Message was sent while issue was closed.
Oh I see, this is on the "sender" side, so AVDA always gets a value now if it's
not initalized.

Powered by Google App Engine
This is Rietveld 408576698