Fixes #519

Fixes #519

This is the Symbol bug which is breaking package:unittest.

R=leafp@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/0325e6c2829b7fad769c7fae9d0a1750bea11c6a

[vsm, 2016-04-22 18:23:43]

Description was changed from

==========
Fixes #519

This is the Symbol bug which is breaking package:unittest.
==========

to

==========
Fixes #519

This is the Symbol bug which is breaking package:unittest.
==========

[vsm, 2016-04-22 18:23:43]

vsm@google.com changed reviewers:
+ jmesserly@google.com, leafp@google.com

[vsm, 2016-04-22 18:23:49]

https://codereview.chromium.org/1915533004/diff/1/lib/src/compiler/code_gener...
File lib/src/compiler/code_generator.dart (left):

https://codereview.chromium.org/1915533004/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:3437: return new
JS.New(_emitTypeName(types.symbolType), [name]);
Note: we need #.new to invoke the factory constructor on core.Symbol (which is
an abstract class).  We were instantiating the abstract class instead.

[Leaf, 2016-04-22 18:26:11]

lgtm

[vsm, 2016-04-22 18:27:06]

Description was changed from

==========
Fixes #519

This is the Symbol bug which is breaking package:unittest.
==========

to

==========
Fixes #519

This is the Symbol bug which is breaking package:unittest.

R=leafp@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/0325e6c2829b7fad769c7fae9d0a...
==========

[vsm, 2016-04-22 18:27:08]

Committed patchset #1 (id:1) manually as
0325e6c2829b7fad769c7fae9d0a1750bea11c6a (presubmit successful).

[Jennifer Messerly, 2016-04-25 16:31:09]

https://codereview.chromium.org/1915533004/diff/1/lib/src/compiler/code_gener...
File lib/src/compiler/code_generator.dart (left):

https://codereview.chromium.org/1915533004/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:3437: return new
JS.New(_emitTypeName(types.symbolType), [name]);
On 2016/04/22 18:23:49, vsm wrote:
> Note: we need #.new to invoke the factory constructor on core.Symbol (which is
> an abstract class).  We were instantiating the abstract class instead.

Nice. I wonder if instead of hard coding we should try and go through the normal
emitConstructor code path? That would prevent this kind of bug from recurring in
the future :)

[Jennifer Messerly, 2016-04-25 16:31:15]

also lgtm