Issue 19155002: Introduce toHTMLIFrameElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19155002: Introduce toHTMLIFrameElement (Closed)

Created:
7 years, 5 months ago by kangil_

Modified:
7 years, 5 months ago

Reviewers:
tkent, haraken

CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, eae+blinkwatch, leviw+renderwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears, Nate Chapin, do-not-use

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Introduce toHTMLIFrameElement To avoid direct use of static_cast, this patch introduces toHTMLIFrameElement for code cleanup. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154214

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -7 lines)			Patch
M	Source/bindings/v8/V8WindowShell.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/core/html/HTMLIFrameElement.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderEmbeddedObject.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderIFrame.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19155002/1

7 years, 5 months ago (2013-07-15 09:06:26 UTC) #4

Message was sent while issue was closed.

Change committed as 154214

Expand Messages | Collapse Messages