Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1915493003: [iOS] Remove dependency on //mojo on iOS due to build failure. (Closed)

Created:
4 years, 8 months ago by sdefresne
Modified:
4 years, 8 months ago
CC:
chromium-reviews, Ken Rockot(use gerrit already)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Remove dependency on //mojo on iOS due to build failure. http://crrev.com/1832703002 introduced a dependency on //third_party/WebKit that cause build failures when using Xcode version of clang (loading clang plugin fails). http://crrev.com/1910843002 tried to disable mojo_public_bindings_unittests only, but the build present the same breakage after the latest roll. Disable all mojo targets until the dependency on third_party/WebKit is fixed. BUG=605508 Committed: https://crrev.com/b582bd87eef350aed20c52eb552bf5e101e01b58 Cr-Commit-Position: refs/heads/master@{#389129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M build/all.gyp View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
sdefresne
eugenebut: please take a look thakis: for OWNERS approval rockot: FYI
4 years, 8 months ago (2016-04-22 14:44:42 UTC) #2
sdefresne
+lpromero: FYI
4 years, 8 months ago (2016-04-22 14:44:55 UTC) #3
lpromero
On 2016/04/22 14:44:55, sdefresne wrote: > +lpromero: FYI Thanks LGTM
4 years, 8 months ago (2016-04-22 14:45:35 UTC) #4
Eugene But (OOO till 7-30)
lgtm :(
4 years, 8 months ago (2016-04-22 14:48:55 UTC) #5
Nico
lgtm if you don't run these tests on any bots
4 years, 8 months ago (2016-04-22 15:04:52 UTC) #6
sdefresne
On 2016/04/22 at 15:04:52, thakis wrote: > lgtm if you don't run these tests on ...
4 years, 8 months ago (2016-04-22 15:08:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915493003/1
4 years, 8 months ago (2016-04-22 15:09:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 16:08:10 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:48:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b582bd87eef350aed20c52eb552bf5e101e01b58
Cr-Commit-Position: refs/heads/master@{#389129}

Powered by Google App Engine
This is Rietveld 408576698