Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1915483004: Add armv8 support for 32-bit building (Closed)

Created:
4 years, 8 months ago by antz
Modified:
4 years, 8 months ago
Reviewers:
slan, brettw, bcf, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add armv8 support for 32-bit building Updated config to build 32-bit for armv8-a. BUG=internal b/28255481 Committed: https://crrev.com/fe6d4d102f10b6b746dd35e960abd456ce14cb88 Cr-Commit-Position: refs/heads/master@{#389330}

Patch Set 1 #

Patch Set 2 : git show #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M build/config/arm.gni View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
antz
4 years, 8 months ago (2016-04-22 20:33:54 UTC) #2
brettw
lgtm
4 years, 8 months ago (2016-04-22 20:42:13 UTC) #3
slan
lgtm
4 years, 8 months ago (2016-04-22 22:05:04 UTC) #4
antz
git cl upload somehow combined two of my patches, reverting to PS1 state
4 years, 8 months ago (2016-04-22 23:13:17 UTC) #5
bcf
lgtm
4 years, 8 months ago (2016-04-22 23:24:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915483004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915483004/40001
4 years, 8 months ago (2016-04-22 23:52:44 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-23 00:43:43 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-23 00:45:09 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fe6d4d102f10b6b746dd35e960abd456ce14cb88
Cr-Commit-Position: refs/heads/master@{#389330}

Powered by Google App Engine
This is Rietveld 408576698