Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 1915473003: goma: back to build-provided client and disable oauth2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json ('k') | scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium/api.py
diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py
index 09b8bc9a4171bd4c11ce84325cb95a2904cba442..612b1b87e67b2aa77f203d8c4c47ba1354e98068 100644
--- a/scripts/slave/recipe_modules/chromium/api.py
+++ b/scripts/slave/recipe_modules/chromium/api.py
@@ -175,8 +175,6 @@ class ChromiumApi(recipe_api.RecipeApi):
if 'goma' in self.c.compile_py.compiler:
args += [
'--goma-jsonstatus', self.m.json.output(),
- '--goma-service-account-json-file',
- self.m.goma.service_account_json_path,
]
if out_dir:
args += ['--out-dir', out_dir]
@@ -466,7 +464,7 @@ class ChromiumApi(recipe_api.RecipeApi):
def ensure_goma(self):
# TODO(phajdan.jr): make cipd-fetched goma work on chromeos.
- if self.c.gyp_env.GYP_DEFINES.get('chromeos') == 1:
+ if self.c.gyp_env.GYP_DEFINES.get('chromeos') == 1: # pragma: no cover
return
goma_dir = self.m.goma.ensure_goma()
« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json ('k') | scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698