Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_Builder.json

Issue 1915473003: goma: back to build-provided client and disable oauth2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_Builder.json
diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_Builder.json b/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_Builder.json
index cc7e47fcb9a8fce43c110ae1a0d787fc9fcc24c4..4f40eb0f2f96efd17fa9e2bf7b766938fc7625b1 100644
--- a/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_Builder.json
+++ b/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_Builder.json
@@ -129,63 +129,6 @@
]
},
{
- "cmd": [],
- "cwd": "[SLAVE_BUILD]",
- "name": "ensure_goma"
- },
- {
- "cmd": [
- "python",
- "-u",
- "RECIPE_MODULE[build::cipd]\\resources\\bootstrap.py",
- "--platform",
- "windows-386",
- "--dest-directory",
- "[SLAVE_BUILD]\\cipd",
- "--json-output",
- "/path/to/tmp/json"
- ],
- "cwd": "[SLAVE_BUILD]",
- "name": "ensure_goma.install cipd",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@",
- "@@@STEP_TEXT@cipd instance_id: 40-chars-fake-of-the-package-instance_id@@@",
- "@@@STEP_LOG_LINE@json.output@{@@@",
- "@@@STEP_LOG_LINE@json.output@ \"executable\": \"[SLAVE_BUILD]\\\\cipd\\\\cipd\", @@@",
- "@@@STEP_LOG_LINE@json.output@ \"instance_id\": \"40-chars-fake-of-the-package-instance_id\"@@@",
- "@@@STEP_LOG_LINE@json.output@}@@@",
- "@@@STEP_LOG_END@json.output@@@"
- ]
- },
- {
- "cmd": [
- "[SLAVE_BUILD]\\cipd\\cipd",
- "ensure",
- "--root",
- "[CACHE]\\cipd\\goma",
- "--list",
- "infra_internal/goma/client/windows-amd64 release",
- "--json-output",
- "/path/to/tmp/json",
- "--service-account-json",
- "C:\\creds\\service_accounts\\service-account-goma-client.json"
- ],
- "cwd": "[SLAVE_BUILD]",
- "name": "ensure_goma.ensure_installed",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@",
- "@@@STEP_LOG_LINE@json.output@{@@@",
- "@@@STEP_LOG_LINE@json.output@ \"result\": [@@@",
- "@@@STEP_LOG_LINE@json.output@ {@@@",
- "@@@STEP_LOG_LINE@json.output@ \"instance_id\": \"resolved-instance_id-of-release---------\", @@@",
- "@@@STEP_LOG_LINE@json.output@ \"package\": \"infra_internal/goma/client/windows-amd64\"@@@",
- "@@@STEP_LOG_LINE@json.output@ }@@@",
- "@@@STEP_LOG_LINE@json.output@ ]@@@",
- "@@@STEP_LOG_LINE@json.output@}@@@",
- "@@@STEP_LOG_END@json.output@@@"
- ]
- },
- {
"cmd": [
"python",
"-u",
@@ -194,7 +137,7 @@
],
"cwd": "[SLAVE_BUILD]",
"env": {
- "GYP_DEFINES": "blink_logging_always_on=1 chromium_win_pch=0 component=static_library dcheck_always_on=1 fastbuild=1 ffmpeg_branding=Chrome gomadir='[CACHE]\\cipd\\goma' proprietary_codecs=1 target_arch=ia32 use_goma=1",
+ "GYP_DEFINES": "blink_logging_always_on=1 chromium_win_pch=0 component=static_library dcheck_always_on=1 fastbuild=1 ffmpeg_branding=Chrome gomadir='[BUILD]\\goma' proprietary_codecs=1 target_arch=ia32 use_goma=1",
"PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools]"
},
"name": "gclient runhooks"
@@ -275,10 +218,8 @@
"goma",
"--goma-jsonstatus",
"/path/to/tmp/json",
- "--goma-service-account-json-file",
- "C:\\creds\\service_accounts\\service-account-goma-client.json",
"--goma-dir",
- "[CACHE]\\cipd\\goma",
+ "[BUILD]\\goma",
"--",
"browser_tests",
"chromium_builder_webrtc",

Powered by Google App Engine
This is Rietveld 408576698