Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1915473002: Add a testing switch to override the query for other forms of browsing history (Closed)

Created:
4 years, 8 months ago by msramek
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Add a testing switch to override the query for other forms of browsing history The API to query other forms of browsing history is not ready yet. The query done by web history service therefore currently always return false, i.e. "no other forms of browsing history found in this account". Until the API is ready, provide a switch for testing purposes that will change this to always return true. BUG=602629 Review URL: https://codereview.chromium.org/1884553002 Cr-Commit-Position: refs/heads/master@{#388753} (cherry picked from commit 2b3e76a0b6974e86953e3786fad5ddafa59cd573) Committed: https://chromium.googlesource.com/chromium/src/+/14ef220fa7d5e12accc0c64099d7f0b5a72ebcc2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -164 lines) Patch
M chrome/browser/ui/webui/history_ui.cc View 3 chunks +18 lines, -0 lines 0 comments Download
M components/browsing_data_ui/history_notice_utils.h View 1 chunk +10 lines, -0 lines 0 comments Download
M components/browsing_data_ui/history_notice_utils.cc View 2 chunks +8 lines, -1 line 0 comments Download
M ios/chrome/app/resources/history/history.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D ios/chrome/browser/ui/webui/history/history_ui.cc View 1 chunk +0 lines, -159 lines 0 comments Download
A + ios/chrome/browser/ui/webui/history/history_ui.mm View 3 chunks +18 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
msramek
4 years, 8 months ago (2016-04-22 14:19:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
14ef220fa7d5e12accc0c64099d7f0b5a72ebcc2.

Powered by Google App Engine
This is Rietveld 408576698