recipe_modules/git/example.py - Issue 1915463002: depot_tools: add infra_paths recipe module for infra-specific paths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_modules/git/example.py

Issue 1915463002: depot_tools: add infra_paths recipe module for infra-specific paths (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« recipe_modules/bot_update/example.expected/basic.json ('K') | « recipe_modules/git/api.py ('k') | recipe_modules/git/example.expected/basic.json » ('j') | recipe_modules/infra_paths/api.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: recipe_modules/git/example.py

diff --git a/recipe_modules/git/example.py b/recipe_modules/git/example.py

index 066785a2a3c00cc8dff2a4f69912cd24346f0d62..02836b45c4cde2d4d64c5f0c4aff8505bd1cd791 100644

--- a/recipe_modules/git/example.py

+++ b/recipe_modules/git/example.py

@@ -4,6 +4,7 @@

DEPS = [

'git',

+ 'infra_paths',

'recipe_engine/path',

'recipe_engine/platform',

'recipe_engine/properties',

@@ -19,7 +20,7 @@ def RunSteps(api):

# useful for debugging git access issues that are reproducible only on bots.

curl_trace_file = None

if api.properties.get('use_curl_trace'):

- curl_trace_file = api.path['slave_build'].join('curl_trace.log')

+ curl_trace_file = api.infra_paths['slave_build'].join('curl_trace.log')

submodule_update_force = api.properties.get('submodule_update_force', False)

submodule_update_recursive = api.properties.get('submodule_update_recursive',

@@ -80,7 +81,7 @@ def RunSteps(api):

# Bundle the repository.

api.git.bundle_create(

- api.path['slave_build'].join('all.bundle'))

+ api.infra_paths['slave_build'].join('all.bundle'))

def GenTests(api):