Issue 1915443002: Enable the use of spaces within a benchmark measurement name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1915443002: Enable the use of spaces within a benchmark measurement name (Closed)

Created:
4 years, 8 months ago by etiennej

Modified:
4 years, 8 months ago

Reviewers:
ppi

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Enable the use of spaces within a benchmark measurement name R=ppi@chromium.org, ppi Committed: https://chromium.googlesource.com/external/mojo/+/9486d2ba193113c66af5f8b62aa4be6f00e74a61

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	apps/benchmark/run_args.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download
	M	mojo/devtools/common/devtoolslib/benchmark.py	View		3 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

etiennej

4 years, 8 months ago (2016-04-22 13:46:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9486d2ba193113c66af5f8b62aa4be6f00e74a61 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages