mojom/mojom_tool/parser/parse_driver.go - Issue 1915413002: Mojom frontend: Detect Ill-founded Types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojom/mojom_tool/parser/parse_driver.go

Issue 1915413002: Mojom frontend: Detect Ill-founded Types (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Fix comments as per code review. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojom/mojom_tool/parser/parse_driver.go

diff --git a/mojom/mojom_tool/parser/parse_driver.go b/mojom/mojom_tool/parser/parse_driver.go

index d058a99528ce602fcbf07d4526d41c242fc6c5c2..f7b71bb4905572a562a08c02219fe0f4bab672a6 100644

--- a/mojom/mojom_tool/parser/parse_driver.go

+++ b/mojom/mojom_tool/parser/parse_driver.go

@@ -170,7 +170,12 @@ func (d *ParseDriver) ParseFiles(fileNames []string) (descriptor *mojom.MojomDes

}

// Compute data for generators.

- err = descriptor.ComputeFinalData()

+ if err = descriptor.ComputeFinalData(); err != nil {

+ return

+ }

+ // Check for ill-founded types.

+ err = descriptor.DetectIllFoundedTypes()

return

}