Get rid of special casing for SVGNumber in the bindings generator

Source/bindings/v8/custom/V8SVGNumberCustom.cpp

 /*
- * Copyright (C) 2010 Google Inc.  All rights reserved.
+ * Copyright (C) 2013 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
  * copyright notice, this list of conditions and the following disclaimer
  * in the documentation and/or other materials provided with the
@@ skipping 10 matching lines @@
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 
-#include "modules/filesystem/FileWriterBase.h"
-
-#include "core/dom/ExceptionCode.h"
-#include "core/dom/ProgressEvent.h"
-#include "core/fileapi/Blob.h"
-#include "core/fileapi/FileError.h"
-#include "modules/filesystem/AsyncFileWriter.h"
+#include "V8SVGNumber.h"
 
 namespace WebCore {
 
-FileWriterBase::~FileWriterBase()
+void V8SVGNumber::valueAttrGetterCustom(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)

[haraken, 2013/07/15 10:59:15]

I guess this getter doesn't need to be custom. You can use
[ImplementedAs=propertyReference], or you can add a helper method
SVGNumber::value() that redirects to SVGNumber::propertyReference().

[do-not-use, 2013/07/15 11:11:14]

This does not work. SVGNumber is a typedef to float.
I tried the ImplementedAs approach and it resulted in the following code: 
    SVGPropertyTearOff<SVGNumber>* wrapper =
V8SVGNumber::toNative(info.Holder());
    SVGNumber& impInstance = wrapper->propertyReference();
    SVGNumber* imp = &impInstance;
    v8SetReturnValue(info, imp->propertyReference());

// imp->propertyReference() is wrong is imp is a float*.

I will see if I find a way to get rid of custom code though...

 {
+    SVGPropertyTearOff<SVGNumber>* wrapper = V8SVGNumber::toNative(info.Holder());
+    SVGNumber& impl = wrapper->propertyReference();
+    v8SetReturnValue(info, impl);
 }
 
-void FileWriterBase::initialize(PassOwnPtr<AsyncFileWriter> writer, long long length)
+void V8SVGNumber::valueAttrSetterCustom(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
 {
-    ASSERT(!m_writer);
-    ASSERT(length >= 0);
-    m_writer = writer;
-    m_length = length;
-}
-
-FileWriterBase::FileWriterBase()
-    : m_position(0)
-{
-}
-
-void FileWriterBase::seekInternal(long long position)
-{
-    if (position > m_length)
-        position = m_length;
-    else if (position < 0)
-        position = m_length + position;
-    if (position < 0)
-        position = 0;
-    m_position = position;
+    SVGPropertyTearOff<SVGNumber>* wrapper = V8SVGNumber::toNative(info.Holder());
+    if (wrapper->isReadOnly()) {
+        setDOMException(NoModificationAllowedError, info.GetIsolate());
+        return;
+    }
+    SVGNumber& impl = wrapper->propertyReference();
+    V8TRYCATCH_VOID(SVGNumber, v, static_cast<float>(value->NumberValue()));
+    impl = v;
+    wrapper->commitChange();

[haraken, 2013/07/15 10:59:15]

Would it be possible to get rid of the custom setter? (I'm not sure.) You might
be able to implement some helper method in SVGNumber and move the isReadOnly()
check, wrapper->propertyReference() and wrapper->commitChange() into the helper
method. Then we can use normal generated code.

 }
 
 } // namespace WebCore