[Custom Tabs] Postpone RecordAction until native libray is loaded

[Custom Tabs] Postpone RecordAction until native libray is loaded

There are some crashes when the BottomBar showing logic happens before
the native library is loaded. This CL fixes by utilizing our tiny infra
in LaunchMetrics to record actions.

BUG=607009
Committed: https://crrev.com/54e8f997ba2f1276fed6430bb3c49f4f1a4b717d
Cr-Commit-Position: refs/heads/master@{#389970}

[Ian Wen, 2016-04-27 00:19:57]

ianwen@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gone, 2016-04-27 00:30:09]

https://codereview.chromium.org/1915393003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java
(right):

https://codereview.chromium.org/1915393003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java:122:
final String actionName = "CustomTabsRemoteViewsUpdated";
nit: maybe pull this up to a class level private static final String?

https://codereview.chromium.org/1915393003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/metrics/LaunchMetrics.java
(right):

https://codereview.chromium.org/1915393003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/metrics/LaunchMetrics.java:51:

private boolean mNeedsToBeRecorded = true;


protected void commitAndClear() {
    if (mNeedsToBeRecorded) RecordUserAction.record(mHistogramName);
    mNeedsToBeRecorded = false;
}

[Ian Wen, 2016-04-27 00:39:44]

All addressed. PTAL

https://codereview.chromium.org/1915393003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java
(right):

https://codereview.chromium.org/1915393003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java:122:
final String actionName = "CustomTabsRemoteViewsUpdated";
On 2016/04/27 00:30:09, dfalcantara wrote:
> nit: maybe pull this up to a class level private static final String?

Done.

https://codereview.chromium.org/1915393003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/metrics/LaunchMetrics.java
(right):

https://codereview.chromium.org/1915393003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/metrics/LaunchMetrics.java:51:

On 2016/04/27 00:30:09, dfalcantara wrote:
> private boolean mNeedsToBeRecorded = true;
> 
> 
> protected void commitAndClear() {
>     if (mNeedsToBeRecorded) RecordUserAction.record(mHistogramName);
>     mNeedsToBeRecorded = false;
> }

Done.

[gone, 2016-04-27 00:48:36]

lgtm

[Ian Wen, 2016-04-27 00:49:08]

The CQ bit was checked by ianwen@chromium.org

[commit-bot: I haz the power, 2016-04-27 00:49:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1915393003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1915393003/20001

[commit-bot: I haz the power, 2016-04-27 01:56:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-27 01:57:24]

Description was changed from

==========
[Custom Tabs] Postpone RecordAction until native libray is loaded

There are some crashes when the BottomBar showing logic happens before
the native library is loaded. This CL fixes by utilizing our tiny infra
in LaunchMetrics to record actions.

BUG=607009
==========

to

==========
[Custom Tabs] Postpone RecordAction until native libray is loaded

There are some crashes when the BottomBar showing logic happens before
the native library is loaded. This CL fixes by utilizing our tiny infra
in LaunchMetrics to record actions.

BUG=607009

Committed: https://crrev.com/54e8f997ba2f1276fed6430bb3c49f4f1a4b717d
Cr-Commit-Position: refs/heads/master@{#389970}
==========

[commit-bot: I haz the power, 2016-04-27 01:57:25]

Patchset 2 (id:??) landed as
https://crrev.com/54e8f997ba2f1276fed6430bb3c49f4f1a4b717d
Cr-Commit-Position: refs/heads/master@{#389970}