Include a ComponentName in bookmark intents

Include a ComponentName in bookmark intents

Include the activity ComponentName in intents to open bookmark urls
so that they are open in the correct activity for Android N
multi-instance.

BUG=603344
Committed: https://crrev.com/7e6cbeac2c20024f02c280a5eadd544563cec274
Cr-Commit-Position: refs/heads/master@{#390072}

[Theresa, 2016-04-26 00:24:17]

twellington@chromium.org changed reviewers:
+ ianwen@chromium.org

[Theresa, 2016-04-26 00:24:17]

ptal

[Ian Wen, 2016-04-26 20:58:06]

https://chromiumcodereview.appspot.com/1915353002/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
(right):

https://chromiumcodereview.appspot.com/1915353002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java:255:
ChromeLauncherActivity.class.getName());
Remove #254 as we are setting component twice?

[Theresa, 2016-04-27 00:39:35]

https://codereview.chromium.org/1915353002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
(right):

https://codereview.chromium.org/1915353002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java:255:
ChromeLauncherActivity.class.getName());
On 2016/04/26 20:58:06, Ian Wen wrote:
> Remove #254 as we are setting component twice?

Done.

[Ian Wen, 2016-04-27 00:40:46]

lgtm Thanks!

[Theresa, 2016-04-27 00:43:25]

twellington@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Theresa, 2016-04-27 00:43:25]

+dfalcantara@ for OWNERS review

[gone, 2016-04-27 01:21:15]

lgtm

https://chromiumcodereview.appspot.com/1915353002/diff/40001/chrome/android/j...
File chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
(right):

https://chromiumcodereview.appspot.com/1915353002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java:90:
public static final String EXTRA_PARENT_COMPONENT =
"com.android.chrome.parent_component";
Wrong package nowadays, but I'll leave it up to you.  EXTRA_REFERRER_ID and
EXTRA_TIMESTAMP_MS use the right one, FWIW.

[Theresa, 2016-04-27 02:41:55]

https://chromiumcodereview.appspot.com/1915353002/diff/40001/chrome/android/j...
File chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
(right):

https://chromiumcodereview.appspot.com/1915353002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java:90:
public static final String EXTRA_PARENT_COMPONENT =
"com.android.chrome.parent_component";
On 2016/04/27 01:21:15, dfalcantara wrote:
> Wrong package nowadays, but I'll leave it up to you.  EXTRA_REFERRER_ID and
> EXTRA_TIMESTAMP_MS use the right one, FWIW.

Done.

[Theresa, 2016-04-27 02:42:07]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2016-04-27 02:42:07]

The patchset sent to the CQ was uploaded after l-g-t-m from ianwen@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1915353002/#ps60001
(title: "Use correct package in intent extra")

[commit-bot: I haz the power, 2016-04-27 02:42:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1915353002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1915353002/60001

[commit-bot: I haz the power, 2016-04-27 02:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 02:48:54]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Theresa, 2016-04-27 14:42:16]

The CQ bit was checked by twellington@chromium.org

[commit-bot: I haz the power, 2016-04-27 14:42:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1915353002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1915353002/60001

[commit-bot: I haz the power, 2016-04-27 14:51:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-27 14:53:05]

Description was changed from

==========
Include a ComponentName in bookmark intents

Include the activity ComponentName in intents to open bookmark urls
so that they are open in the correct activity for Android N
multi-instance.

BUG=603344
==========

to

==========
Include a ComponentName in bookmark intents

Include the activity ComponentName in intents to open bookmark urls
so that they are open in the correct activity for Android N
multi-instance.

BUG=603344

Committed: https://crrev.com/7e6cbeac2c20024f02c280a5eadd544563cec274
Cr-Commit-Position: refs/heads/master@{#390072}
==========

[commit-bot: I haz the power, 2016-04-27 14:53:06]

Patchset 4 (id:??) landed as
https://crrev.com/7e6cbeac2c20024f02c280a5eadd544563cec274
Cr-Commit-Position: refs/heads/master@{#390072}