third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 1915343003: Add CSS hyphens property behind the test flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 1915343003: Add CSS hyphens property behind the test flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Re-use UseCounter value for -webkit-hyphens and include change to histograms.xml Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h ('K') | « third_party/WebKit/Source/core/css/CSSValueKeywords.in ('k') | third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp » ('j') | third_party/WebKit/Source/core/style/ComputedStyleConstants.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index 381e4f73cb99ee15f9ff9439b3aafcbe43270abd..b3f848692c4c3975d8009387d5712b84d7d3c90e 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -1818,6 +1818,8 @@ CSSValue* ComputedStyleCSSValueMapping::get(CSSPropertyID propertyID, const Comp

if (style.highlight() == nullAtom)

return cssValuePool().createIdentifierValue(CSSValueNone);

return CSSStringValue::create(style.highlight());

+ case CSSPropertyHyphens:

+ return cssValuePool().createValue(style.hyphens());

case CSSPropertyWebkitHyphenateCharacter:

if (style.hyphenationString().isNull())

return cssValuePool().createIdentifierValue(CSSValueAuto);