Add CSS hyphens property behind the test flag

Add CSS hyphens property behind the test flag

This patch adds the CSS hyphens property behind the test flag.

This property was once added then removed in crbug.com/47083. The
member field in StyleRareInheritedData was not removed and and thus
changes to StyleRareInheritedData and ComputedStyle::diffNeeds* are
already in place.

BUG=605840
Committed: https://crrev.com/15c6e50b51e8da0393a001a03c50b38f51eb1c01
Cr-Commit-Position: refs/heads/master@{#389986}

[kojii, 2016-04-26 04:30:08]

Description was changed from

==========
hyphens

BUG=605840
==========

to

==========
Add CSS hyphens property behind the test flag

This patch adds the CSS hyphens property behind the test flag.

This property was once added then removed in crbug.com/47083. The
fields in StyleRareInheritedData was not removed and re-used, so this
patch does not include changes to StyleRareInheritedData and to
ComputedStyle::diffNeeds* functions.

BUG=605840
==========

[kojii, 2016-04-26 04:36:49]

Description was changed from

==========
Add CSS hyphens property behind the test flag

This patch adds the CSS hyphens property behind the test flag.

This property was once added then removed in crbug.com/47083. The
fields in StyleRareInheritedData was not removed and re-used, so this
patch does not include changes to StyleRareInheritedData and to
ComputedStyle::diffNeeds* functions.

BUG=605840
==========

to

==========
Add CSS hyphens property behind the test flag

This patch adds the CSS hyphens property behind the test flag.

This property was once added then removed in crbug.com/47083. The
fields in StyleRareInheritedData was not removed and and thus changes
to StyleRareInheritedData and ComputedStyle::diffNeeds* are already in
place.

BUG=605840
==========

[kojii, 2016-04-26 05:34:06]

Description was changed from

==========
Add CSS hyphens property behind the test flag

This patch adds the CSS hyphens property behind the test flag.

This property was once added then removed in crbug.com/47083. The
fields in StyleRareInheritedData was not removed and and thus changes
to StyleRareInheritedData and ComputedStyle::diffNeeds* are already in
place.

BUG=605840
==========

to

==========
Add CSS hyphens property behind the test flag

This patch adds the CSS hyphens property behind the test flag.

This property was once added then removed in crbug.com/47083. The
member field in StyleRareInheritedData was not removed and and thus
changes to StyleRareInheritedData and ComputedStyle::diffNeeds* are
already in place.

BUG=605840
==========

[kojii, 2016-04-26 05:44:16]

Description was changed from

==========
Add CSS hyphens property behind the test flag

This patch adds the CSS hyphens property behind the test flag.

This property was once added then removed in crbug.com/47083. The
member field in StyleRareInheritedData was not removed and and thus
changes to StyleRareInheritedData and ComputedStyle::diffNeeds* are
already in place.

BUG=605840
==========

to

==========
Add CSS hyphens property behind the test flag

This patch adds the CSS hyphens property behind the test flag.

This property was once added then removed in crbug.com/47083. The
member field in StyleRareInheritedData was not removed and and thus
changes to StyleRareInheritedData and ComputedStyle::diffNeeds* are
already in place.

The UseCounter value re-uses the one for -webkit-hyphens.

BUG=605840
==========

[kojii, 2016-04-26 06:37:04]

Description was changed from

==========
Add CSS hyphens property behind the test flag

This patch adds the CSS hyphens property behind the test flag.

This property was once added then removed in crbug.com/47083. The
member field in StyleRareInheritedData was not removed and and thus
changes to StyleRareInheritedData and ComputedStyle::diffNeeds* are
already in place.

The UseCounter value re-uses the one for -webkit-hyphens.

BUG=605840
==========

to

==========
Add CSS hyphens property behind the test flag

This patch adds the CSS hyphens property behind the test flag.

This property was once added then removed in crbug.com/47083. The
member field in StyleRareInheritedData was not removed and and thus
changes to StyleRareInheritedData and ComputedStyle::diffNeeds* are
already in place.

The UseCounter value re-uses the exiting value for -webkit-hyphens.

BUG=605840
==========

[kojii, 2016-04-26 07:05:08]

kojii@chromium.org changed reviewers:
+ holte@chromium.org, timloh@chromium.org, tkent@chromium.org

[kojii, 2016-04-26 07:05:09]

timloh@, PTAL for css/style
holte@, PTAL for tools/metrics
tkent@, PTAL for frames

[tkent, 2016-04-26 07:08:51]

https://codereview.chromium.org/1915343003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h (right):

https://codereview.chromium.org/1915343003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:1421:
ASSERT(isValueID());
Please use DCHECK for new code.

https://codereview.chromium.org/1915343003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:1433:
ASSERT_NOT_REACHED();
Please use NOTREACHED for new code.

https://codereview.chromium.org/1915343003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/ComputedStyleConstants.h (right):

https://codereview.chromium.org/1915343003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/ComputedStyleConstants.h:465: enum EHyphens
{ HyphensNone, HyphensManual, HyphensAuto };
Don't use 'E' prefix.  It's KHTML-era coding style.

[kojii, 2016-04-26 07:38:03]

Thank you for your prompt review.

https://codereview.chromium.org/1915343003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h (right):

https://codereview.chromium.org/1915343003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:1421:
ASSERT(isValueID());
On 2016/04/26 at 07:08:50, tkent wrote:
> Please use DCHECK for new code.

Done, copy-pasted without checking, thanks.

https://codereview.chromium.org/1915343003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:1433:
ASSERT_NOT_REACHED();
On 2016/04/26 at 07:08:51, tkent wrote:
> Please use NOTREACHED for new code.

Done.

https://codereview.chromium.org/1915343003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/ComputedStyleConstants.h (right):

https://codereview.chromium.org/1915343003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/ComputedStyleConstants.h:465: enum EHyphens
{ HyphensNone, HyphensManual, HyphensAuto };
On 2016/04/26 at 07:08:51, tkent wrote:
> Don't use 'E' prefix.  It's KHTML-era coding style.

Done, didn't know that, added type_name=Hyphens to CSSProperties.in.

[tkent, 2016-04-26 07:41:34]

lgtm.
Please wait for timloh's review.

[Timothy Loh, 2016-04-26 08:19:08]

lgtm but I think it's better to use a new UseCounter value rather than re-use
the value from -webkit-hyphens.

https://codereview.chromium.org/1915343003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSValueKeywords.in (right):

https://codereview.chromium.org/1915343003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSValueKeywords.in:609: // hyphens
I wouldn't bother with the comments, I don't think they're useful.

[kojii, 2016-04-26 08:39:53]

> I think it's better to use a new UseCounter value rather than re-use the value
from -webkit-hyphens.

Done, assigned a new value.

https://codereview.chromium.org/1915343003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSValueKeywords.in (right):

https://codereview.chromium.org/1915343003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSValueKeywords.in:609: // hyphens
On 2016/04/26 at 08:19:08, Timothy Loh wrote:
> I wouldn't bother with the comments, I don't think they're useful.

Done, took simpler style (property name in one line.)

[kojii, 2016-04-26 12:57:42]

Description was changed from

==========
Add CSS hyphens property behind the test flag

This patch adds the CSS hyphens property behind the test flag.

This property was once added then removed in crbug.com/47083. The
member field in StyleRareInheritedData was not removed and and thus
changes to StyleRareInheritedData and ComputedStyle::diffNeeds* are
already in place.

The UseCounter value re-uses the exiting value for -webkit-hyphens.

BUG=605840
==========

to

==========
Add CSS hyphens property behind the test flag

This patch adds the CSS hyphens property behind the test flag.

This property was once added then removed in crbug.com/47083. The
member field in StyleRareInheritedData was not removed and and thus
changes to StyleRareInheritedData and ComputedStyle::diffNeeds* are
already in place.

BUG=605840
==========

[kojii, 2016-04-26 12:57:42]

kojii@chromium.org changed reviewers:
- holte@chromium.org, timloh@chromium.org, tkent@chromium.org

[kojii, 2016-04-26 13:00:08]

kojii@chromium.org changed reviewers:
+ holte@chromium.org, timloh@chromium.org, tkent@chromium.org

[kojii, 2016-04-27 01:27:25]

kojii@chromium.org changed reviewers:
- holte@chromium.org

[kojii, 2016-04-27 03:50:50]

The CQ bit was checked by kojii@chromium.org

[kojii, 2016-04-27 03:50:50]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1915343003/#ps100001
(title: "Split histograms.xml")

[commit-bot: I haz the power, 2016-04-27 03:51:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1915343003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1915343003/100001

[commit-bot: I haz the power, 2016-04-27 03:55:17]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-27 03:56:49]

Description was changed from

==========
Add CSS hyphens property behind the test flag

This patch adds the CSS hyphens property behind the test flag.

This property was once added then removed in crbug.com/47083. The
member field in StyleRareInheritedData was not removed and and thus
changes to StyleRareInheritedData and ComputedStyle::diffNeeds* are
already in place.

BUG=605840
==========

to

==========
Add CSS hyphens property behind the test flag

This patch adds the CSS hyphens property behind the test flag.

This property was once added then removed in crbug.com/47083. The
member field in StyleRareInheritedData was not removed and and thus
changes to StyleRareInheritedData and ComputedStyle::diffNeeds* are
already in place.

BUG=605840

Committed: https://crrev.com/15c6e50b51e8da0393a001a03c50b38f51eb1c01
Cr-Commit-Position: refs/heads/master@{#389986}
==========

[commit-bot: I haz the power, 2016-04-27 03:56:51]

Patchset 6 (id:??) landed as
https://crrev.com/15c6e50b51e8da0393a001a03c50b38f51eb1c01
Cr-Commit-Position: refs/heads/master@{#389986}