Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1915293005: [Android] Make tools/android/forwarder build with the current toolchain. (Closed)

Created:
4 years, 8 months ago by jbudorick
Modified:
4 years, 8 months ago
Reviewers:
Yaron, agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Make tools/android/forwarder build with the current toolchain. BUG=604468 Committed: https://crrev.com/c2e43c5c93451f112a1aefc4d2677a98c1185f7e Cr-Commit-Position: refs/heads/master@{#389812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M tools/android/forwarder/BUILD.gn View 1 chunk +10 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
AFAICT this is only used by blink_tests. I'd like to deprecate it in favor of ...
4 years, 8 months ago (2016-04-26 13:33:47 UTC) #2
agrieve
On 2016/04/26 13:33:47, jbudorick wrote: > AFAICT this is only used by blink_tests. I'd like ...
4 years, 8 months ago (2016-04-26 14:33:33 UTC) #3
Yaron
On 2016/04/26 14:33:33, agrieve wrote: > On 2016/04/26 13:33:47, jbudorick wrote: > > AFAICT this ...
4 years, 8 months ago (2016-04-26 16:07:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915293005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915293005/1
4 years, 8 months ago (2016-04-26 16:12:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 17:11:32 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 17:14:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2e43c5c93451f112a1aefc4d2677a98c1185f7e
Cr-Commit-Position: refs/heads/master@{#389812}

Powered by Google App Engine
This is Rietveld 408576698