Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1915293004: Make Syzygy ordering file optional for official archival. (Closed)

Created:
4 years, 8 months ago by Sigurður Ásgeirsson
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Syzygy ordering file optional for official archival. Official SysyASAN canary builds are currently failing since the profile step is elided and no longer produces this file. TBR=mmoss@chromium.org BUG=605012 Committed: https://crrev.com/da7db7bece401897b4a5932f63930ae0be5ab3b1 Cr-Commit-Position: refs/heads/master@{#389774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/tools/build/win/FILES.cfg View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
grt (UTC plus 2)
rubber-stamp lgtm
4 years, 8 months ago (2016-04-26 13:21:49 UTC) #2
Sigurður Ásgeirsson
Committing TBR for owners.
4 years, 8 months ago (2016-04-26 13:24:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915293004/1
4 years, 8 months ago (2016-04-26 13:24:25 UTC) #7
chrisha
lgtm
4 years, 8 months ago (2016-04-26 13:27:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 14:02:19 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/da7db7bece401897b4a5932f63930ae0be5ab3b1 Cr-Commit-Position: refs/heads/master@{#389774}
4 years, 8 months ago (2016-04-26 14:03:25 UTC) #13
Sébastien Marchand
4 years, 8 months ago (2016-04-26 14:06:14 UTC) #15
Message was sent while issue was closed.
lgtm, thanks. (I was preparing a CL to do this).

Do we really need these files ?

Powered by Google App Engine
This is Rietveld 408576698