Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1915273003: [Mac] Make deviceorientationabsolute implementation conform with the specification. (Closed)

Created:
4 years, 7 months ago by timvolodine
Modified:
4 years, 7 months ago
CC:
chromium-reviews, riju_, Michael van Ouwerkerk, jam, darin-cc_chromium.org, mlamouri+watch-sensors_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Make deviceorientationabsolute implementation conform with the specification. Absolute device orientation cannot be provided on Mac machines. This patch makes sure that this is handled according to spec, i.e. by propagating a one-off all-null event to let the web page know no data can be provided for this event type. spec: http://w3c.github.io/deviceorientation/spec-source-orientation.html TEST=http://timvolodine.github.io/deviceorientation-test/ BUG=609094 Committed: https://crrev.com/7bf8fdb21b7aec50889a725ceea2ebf72d484994 Cr-Commit-Position: refs/heads/master@{#394569}

Patch Set 1 #

Patch Set 2 : add code in Stop() and set absolute to true #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M content/browser/device_sensors/data_fetcher_shared_memory_mac.cc View 1 2 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
timvolodine
4 years, 7 months ago (2016-04-26 15:16:24 UTC) #2
Michael van Ouwerkerk
lgtm Is there a bug number this CL can be associated with?
4 years, 7 months ago (2016-04-27 12:11:23 UTC) #3
timvolodine
On 2016/04/27 12:11:23, Michael van Ouwerkerk wrote: > lgtm > > Is there a bug ...
4 years, 7 months ago (2016-05-18 11:27:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915273003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915273003/20001
4 years, 7 months ago (2016-05-18 16:03:45 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/7732)
4 years, 7 months ago (2016-05-18 16:08:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915273003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915273003/20001
4 years, 7 months ago (2016-05-18 21:20:35 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-18 22:12:53 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 22:14:08 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7bf8fdb21b7aec50889a725ceea2ebf72d484994
Cr-Commit-Position: refs/heads/master@{#394569}

Powered by Google App Engine
This is Rietveld 408576698