Raise exception when devices fail to list tests.

Raise exception when devices fail to list tests.

Before we only make sure that list of test cases are not None, but then
we realise that list of test cases should not be empty too, since
sometimes when devices fail to list tests, they will not return None,
but will return an empty list.

BUG=585585
Committed: https://crrev.com/3d73e44f7177fe1dbb6e868120b985a6c9fb8a30
Cr-Commit-Position: refs/heads/master@{#389576}

[BigBossZhiling, 2016-04-25 20:04:42]

Description was changed from

==========
Raise exception when devices fail to list tests.

Before we only make sure that list of test cases are not None, but then
we realise that list of test cases should not be empty too, since
sometimes when devices fail to list tests, they will not return None,
but will return an empty list.

BUG=585585
==========

to

==========
Raise exception when devices fail to list tests.

Before we only make sure that list of test cases are not None, but then
we realise that list of test cases should not be empty too, since
sometimes when devices fail to list tests, they will not return None,
but will return an empty list.

BUG=585585
==========

[BigBossZhiling, 2016-04-25 20:04:42]

hzl@google.com changed reviewers:
+ jbudorick@chromium.org

[BigBossZhiling, 2016-04-25 20:07:15]

https://codereview.chromium.org/1915273002/diff/1/build/android/pylib/local/d...
File build/android/pylib/local/device/local_device_gtest_run.py (right):

https://codereview.chromium.org/1915273002/diff/1/build/android/pylib/local/d...
build/android/pylib/local/device/local_device_gtest_run.py:324: if all([(tl is
None or not tl) for tl in test_lists]):
But in this case, if a suite indeed has an empty list of test cases, we will
raise an exception, instead of passing 0 test cases. I think that is fine
because we will never have an empty test suite, or what's the point of running
an empty test suite? I guess it's ok to raise an exception when the suite has 0
test case inside it.

[jbudorick, 2016-04-25 20:11:39]

https://codereview.chromium.org/1915273002/diff/1/android_webview/native/aw_g...
File android_webview/native/aw_gl_functor.cc (right):

https://codereview.chromium.org/1915273002/diff/1/android_webview/native/aw_g...
android_webview/native/aw_gl_functor.cc:103:
DCHECK_CURRENTLY_ON(BrowserThread::UI);
This change shouldn't be in this CL.

https://codereview.chromium.org/1915273002/diff/1/build/android/pylib/local/d...
File build/android/pylib/local/device/local_device_gtest_run.py (right):

https://codereview.chromium.org/1915273002/diff/1/build/android/pylib/local/d...
build/android/pylib/local/device/local_device_gtest_run.py:324: if all([(tl is
None or not tl) for tl in test_lists]):
On 2016/04/25 20:07:15, BigBossZhiling wrote:
> But in this case, if a suite indeed has an empty list of test cases, we will
> raise an exception, instead of passing 0 test cases. I think that is fine
> because we will never have an empty test suite, or what's the point of running
> an empty test suite? I guess it's ok to raise an exception when the suite has
0
> test case inside it.

Yeah, I think I'm ok with this in general. However, this should be

  if all(not t1 for t1 in test_lists):

[jbudorick, 2016-04-25 20:22:20]

lgtm

[BigBossZhiling, 2016-04-25 20:22:36]

The CQ bit was checked by hzl@google.com

[commit-bot: I haz the power, 2016-04-25 20:22:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1915273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1915273002/20001

[commit-bot: I haz the power, 2016-04-25 21:58:25]

Description was changed from

==========
Raise exception when devices fail to list tests.

Before we only make sure that list of test cases are not None, but then
we realise that list of test cases should not be empty too, since
sometimes when devices fail to list tests, they will not return None,
but will return an empty list.

BUG=585585
==========

to

==========
Raise exception when devices fail to list tests.

Before we only make sure that list of test cases are not None, but then
we realise that list of test cases should not be empty too, since
sometimes when devices fail to list tests, they will not return None,
but will return an empty list.

BUG=585585
==========

[commit-bot: I haz the power, 2016-04-25 21:58:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-25 22:00:25]

Description was changed from

==========
Raise exception when devices fail to list tests.

Before we only make sure that list of test cases are not None, but then
we realise that list of test cases should not be empty too, since
sometimes when devices fail to list tests, they will not return None,
but will return an empty list.

BUG=585585
==========

to

==========
Raise exception when devices fail to list tests.

Before we only make sure that list of test cases are not None, but then
we realise that list of test cases should not be empty too, since
sometimes when devices fail to list tests, they will not return None,
but will return an empty list.

BUG=585585

Committed: https://crrev.com/3d73e44f7177fe1dbb6e868120b985a6c9fb8a30
Cr-Commit-Position: refs/heads/master@{#389576}
==========

[commit-bot: I haz the power, 2016-04-25 22:00:26]

Patchset 2 (id:??) landed as
https://crrev.com/3d73e44f7177fe1dbb6e868120b985a6c9fb8a30
Cr-Commit-Position: refs/heads/master@{#389576}

[mikecase (-- gone --), 2016-04-26 19:58:17]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1923053002/ by mikecase@chromium.org.

The reason for reverting is: Looks like it is breaking upstream android bots
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg....