Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: src/core/SkLinearBitmapPipeline.cpp

Issue 1915263002: Add guards for edge cases. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkBitmapProcShader.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkLinearBitmapPipeline.cpp
diff --git a/src/core/SkLinearBitmapPipeline.cpp b/src/core/SkLinearBitmapPipeline.cpp
index 415179a0b1683e4ac612bdb3be17bbcb656b6977..221f74d30df84467b3018e06d2d9160a553ba84b 100644
--- a/src/core/SkLinearBitmapPipeline.cpp
+++ b/src/core/SkLinearBitmapPipeline.cpp
@@ -584,11 +584,13 @@ public:
void pointSpan(Span span) override {
SkASSERT(fDest + span.count() <= fEnd);
- int32_t x = (int32_t)span.startX();
- int32_t y = (int32_t)span.startY();
- const uint32_t* src = this->pixelAddress(x, y);
- memmove(fDest, src, span.count() * sizeof(uint32_t));
- fDest += span.count();
+ if (span.length() != 0.0f) {
+ int32_t x = (int32_t)span.startX();
Brian Osman 2016/04/25 20:00:18 Should these be using SkScalarFloorToInt, just to
herb_g 2016/04/25 20:36:36 At this point, I know that startX > 0, so I want t
+ int32_t y = (int32_t)span.startY();
+ const uint32_t* src = this->pixelAddress(x, y);
+ memmove(fDest, src, span.count() * sizeof(uint32_t));
+ fDest += span.count();
+ }
}
void repeatSpan(Span span, int32_t repeatCount) override {
« no previous file with comments | « src/core/SkBitmapProcShader.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698