Add guards for edge cases.

Add guards for edge cases.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915263002

Committed: https://skia.googlesource.com/skia/+/5d4943caae2ee8e2adc1152864304ba9903c2098

[herb_g, 2016-04-25 19:53:17]

Description was changed from

==========
Add guards for edge cases.

BUG=skia:
==========

to

==========
Add guards for edge cases.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-04-25 19:53:59]

Description was changed from

==========
Add guards for edge cases.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add guards for edge cases.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-04-25 19:53:59]

herb@google.com changed reviewers:
+ brianosman@google.com

[herb_g, 2016-04-25 19:54:21]

Two guards to handle missed edge cases.

[Brian Osman, 2016-04-25 20:00:19]

lgtm

https://codereview.chromium.org/1915263002/diff/1/src/core/SkLinearBitmapPipe...
File src/core/SkLinearBitmapPipeline.cpp (right):

https://codereview.chromium.org/1915263002/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:588: int32_t x = (int32_t)span.startX();
Should these be using SkScalarFloorToInt, just to be more explicit about the
conversion that's happening?

[herb_g, 2016-04-25 20:35:36]

Use proper call for trunc.

[herb_g, 2016-04-25 20:36:36]

https://codereview.chromium.org/1915263002/diff/1/src/core/SkLinearBitmapPipe...
File src/core/SkLinearBitmapPipeline.cpp (right):

https://codereview.chromium.org/1915263002/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:588: int32_t x = (int32_t)span.startX();
On 2016/04/25 20:00:18, Brian Osman wrote:
> Should these be using SkScalarFloorToInt, just to be more explicit about the
> conversion that's happening?

At this point, I know that startX > 0, so I want the much faster truncate
behavior. Changed to SkScalarTruncToInt, which I didn't know existed. Thanks.

[herb_g, 2016-04-25 20:36:53]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 20:36:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1915263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1915263002/20001

[commit-bot: I haz the power, 2016-04-25 20:39:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 20:39:07]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[herb_g, 2016-04-26 15:14:26]

The CQ bit was checked by herb@google.com

[herb_g, 2016-04-26 15:14:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
brianosman@google.com
Link to the patchset: https://codereview.chromium.org/1915263002/#ps20001
(title: "Use proper call for trunc.")

[commit-bot: I haz the power, 2016-04-26 15:14:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1915263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1915263002/20001

[commit-bot: I haz the power, 2016-04-26 15:15:29]

Description was changed from

==========
Add guards for edge cases.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add guards for edge cases.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/5d4943caae2ee8e2adc1152864304ba9903c2098
==========

[commit-bot: I haz the power, 2016-04-26 15:15:30]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5d4943caae2ee8e2adc1152864304ba9903c2098