Issue 1915193002: Simplify the organization of //mojo_file_utils.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1915193002: Simplify the organization of //mojo_file_utils. (Closed)

Created:
4 years, 8 months ago by viettrungluu

Modified:
4 years, 8 months ago

Reviewers:
azani

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Simplify the organization of //mojo_file_utils. * It's not public, so there's no need for lib and tests. * There was no real need for file_util_test_base.*. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f8f9321fec33aa3a227ec738512ff2ab2426531c

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -314 lines)			Patch
M	mojo/file_utils/BUILD.gn	View	2 chunks	+2 lines, -4 lines	0 comments	Download
A +	mojo/file_utils/file_util.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	mojo/file_utils/file_util_unittest.cc	View	3 chunks	+6 lines, -4 lines	0 comments	Download
D	mojo/file_utils/lib/file_util.cc	View	1 chunk	+0 lines, -52 lines	0 comments	Download
D	mojo/file_utils/tests/file_util_test_base.h	View	1 chunk	+0 lines, -34 lines	0 comments	Download
D	mojo/file_utils/tests/file_util_test_base.cc	View	1 chunk	+0 lines, -24 lines	0 comments	Download
D	mojo/file_utils/tests/file_util_unittest.cc	View	1 chunk	+0 lines, -197 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

4 years, 8 months ago (2016-04-25 21:36:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f8f9321fec33aa3a227ec738512ff2ab2426531c (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages