Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1915163003: Revert of Set up a parallel memory.memory_health_quick_tbmv2 benchmark (Closed)

Created:
4 years, 8 months ago by perezju
Modified:
4 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Set up a parallel memory.memory_health_quick_tbmv2 benchmark (patchset #4 id:80001 of https://codereview.chromium.org/1907343002/ ) Reason for revert: Broke data upload to perf dashboard for these benchmarks. BUG=606698 Original issue's description: > Set up a parallel memory.memory_health_quick_tbmv2 benchmark > > This patch adds a temporary parallel benchmark to compare the new TBMv2 > memory metric (third_party/catapult/tracing/tracing/metrics/ > system_health/memory_metric.html) with the existing TBMv1 one > (third_party/catapult/telemetry/telemetry/web_perf/metrics/ > memory_timeline.py). > > Once all issues associated with the TBMv2 metric are resolved, all > memory benchmarks will switch to use it instead of the TBMv1 metric and > the temporary parallel benchmark will be removed. > > BUG=581716, 606361 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq > > Committed: https://crrev.com/92efb5bc7f3830436cc047a39e79c5374b5a4d7a > Cr-Commit-Position: refs/heads/master@{#389519} TBR=primiano@chromium.org,nednguyen@google.com,petrcermak@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581716, 606361 Committed: https://crrev.com/1c572b2ccff4c64f3e9aecd526729ffb4e89a00e Cr-Commit-Position: refs/heads/master@{#389726}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -57 lines) Patch
M tools/perf/benchmarks/memory_infra.py View 3 chunks +9 lines, -33 lines 0 comments Download
M tools/perf/page_sets/memory_health_story.py View 3 chunks +10 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
perezju
Created Revert of Set up a parallel memory.memory_health_quick_tbmv2 benchmark
4 years, 8 months ago (2016-04-26 08:48:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915163003/1
4 years, 8 months ago (2016-04-26 08:48:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 08:49:27 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1c572b2ccff4c64f3e9aecd526729ffb4e89a00e Cr-Commit-Position: refs/heads/master@{#389726}
4 years, 8 months ago (2016-04-26 08:50:54 UTC) #6
petrcermak
lgtm
4 years, 8 months ago (2016-04-26 08:57:11 UTC) #7
nednguyen
4 years, 7 months ago (2016-04-27 17:04:31 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1920363003/ by nednguyen@google.com.

The reason for reverting is: Underlied problem should be already fixed.

 .

Powered by Google App Engine
This is Rietveld 408576698