Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 191513003: Check --utility-enable-mdns before local_discovery::ServiceDiscoveryMessageHandler::PreSandboxStart… (Closed)

Created:
6 years, 9 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 9 months ago
Reviewers:
Lei Zhang, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Check --utility-enable-mdns before local_discovery::ServiceDiscoveryMessageHandler::PreSandboxStartup call. BUG=350518 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255829

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/utility/chrome_content_utility_client.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 9 months ago (2014-03-07 21:43:33 UTC) #1
Vitaly Buka (NO REVIEWS)
Nico can you review this one?
6 years, 9 months ago (2014-03-08 01:10:55 UTC) #2
Nico
lgtm Consider adding a comment explaining why this is important (I can't read the bug), ...
6 years, 9 months ago (2014-03-08 01:51:57 UTC) #3
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-08 02:09:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/191513003/1
6 years, 9 months ago (2014-03-08 11:20:25 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 11:45:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 9 months ago (2014-03-08 11:45:09 UTC) #7
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-09 04:35:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/191513003/1
6 years, 9 months ago (2014-03-09 04:35:33 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 06:00:06 UTC) #10
Message was sent while issue was closed.
Change committed as 255829

Powered by Google App Engine
This is Rietveld 408576698